Skip to content
Snippets Groups Projects
  1. Sep 23, 2019
  2. Sep 14, 2019
  3. Sep 08, 2019
  4. Sep 03, 2019
    • Nicolas Dufresne's avatar
      bin: Fix minor race when adding to a bin · 94ba1cea
      Nicolas Dufresne authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      This patch simply add a null check around a case where a child may have
      been unparented concurrently to the deep_add_remove operation. This was
      found by accident in the form of an "IS_GST_OBJECT" assertion, but had
      no other known side effect in that test.
      94ba1cea
  5. Aug 15, 2019
  6. Aug 14, 2019
  7. Aug 11, 2019
    • Alicia Boya García's avatar
      downloadbuffer: Check for flush after seek · 5dbaaa1e
      Alicia Boya García authored and Tim-Philipp Müller's avatar Tim-Philipp Müller committed
      In gst_download_buffer_wait_for_data(), when a seek is made with
      perform_seek_to_offset() the `qlock` is released temporarily. Therefore,
      the flushing condition can be set during this period and should be
      checked.
      
      This was not being checked before, causing occasional deadlocks when
      GST_DOWNLOAD_BUFFER_WAIT_ADD_CHECK() was called.
      
      GST_DOWNLOAD_BUFFER_WAIT_ADD_CHECK() assumes that the caller has already
      checked that we're not flushing before, since this is done when
      acquiring the lock; so if we release it temporarily somewhere, we need
      to check for flush again.
      
      Without that check, the function would keep waiting for the condition
      variable to be notified before checking for flushing condition again,
      and that may very well never happen. This was reproduced when during pad
      deactivation when running WebKit in gdb.
      5dbaaa1e
  8. Aug 09, 2019
  9. Aug 08, 2019
  10. Aug 07, 2019
  11. Aug 06, 2019
Loading