- Sep 21, 2018
-
-
Juan A. Suárez authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Juan A. Suárez authored
Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Was missing the init, found by Emil. Fixes: d17443a4 "radv: Use build ID if available for cache UUID." CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 0a77e70d)
-
- Sep 19, 2018
-
-
Juan A. Suárez authored
fixes: this commit was reverted by commit 95bb7d82. Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com>
-
Reviewed-by:
Iago Toral Quiroga <itoral@igalia.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107879 Cc: "18.2" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 864c7805)
-
When we're about to re-arrange a bunch of blocks, it's a good idea to make sure that we don't have deref uses crossing block boundaries. Otherwise we may end up with a deref going through a phi and that would be bad. Reviewed-by:
Iago Toral Quiroga <itoral@igalia.com> Cc: "18.2" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 0796c393)
-
This pass re-materializes deref instructions on a per-block basis to ensure that every use of a deref occurs in the same block as the instruction which uses it. Reviewed-by:
Iago Toral Quiroga <itoral@igalia.com> Cc: "18.2" <mesa-stable@lists.freedesktop.org> (cherry picked from commit 7d1d1208) [Juan A. Suarez: resolve trivial conflicts] Signed-off-by:
Juan A. Suarez Romero <jasuarez@igalia.com> Conflicts: src/compiler/nir/nir_deref.c Squashed with: nir: add initializer data to fix MSVC compile error CC: Jason Ekstrand <jason@jlekstrand.net> Fixes: 82799a5d1b8 ("nir: Add a small pass to rematerialize derefs per-block") Reviewed-by:
Samuel Iglesias Gonsálvez <siglesias@igalia.com> (cherry picked from commit 0c82e360)
-
No changes here compared to Raven. Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Reviewed-by:
Huang Rui <ray.huang@amd.com> Signed-off-by:
Kenneth Feng <kenneth.feng@amd.com> Signed-off-by:
Huang Rui <ray.huang@amd.com> Cc: 18.1 18.2 <mesa-stable@lists.freedesktop.org> (cherry picked from commit 4490fce1)
-
This reverts commit bc65dcab. This was manually reverted. Reverting stops the menu hanging in some id tech games such as RAGE and Wolfenstein The New Order. Reviewed-by:
Marek Olšák <marek.olsak@amd.com> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107891 (cherry picked from commit 7a992fcf)
-
Missing break; causes parameter checking to never pass GL_FRAMEBUFFER_FLIP_Y_MESA parameters. Fixes: 318c2651 ("mesa: GL_MESA_framebuffer_flip_y extension [v4]") Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit 60d0c0d0)
-
Instances where direction was determined based on winsys or user fbo and should be determined based on FlipY. Key STATE_FB_WPOS_Y_TRANSFORM for of FlipY instead of _mesa_is_user_fbo. This corrects gl_FragCoord usage when applying GL_MESA_framebuffer_flip_y. Fixes: ab05dd18 ("i965: implement GL_MESA_framebuffer_flip_y [v3]") Reviewed-by:
Brian Paul <brianp@vmware.com> (cherry picked from commit ba6cc32c)
-
To get an useful UUID for systems that have a non-useful mtime for the binaries. I started using SHA1 to ensure we get reasonable mixing in the various possibilities and the various build id lengths. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Timothy Arceri <tarceri@itsqueeze.com> (cherry picked from commit d17443a4)
-
Gallium may pick L16A16_FLOAT to represent GL_INTENSITY16F if no intensity format is provided by the driver. However, when calling glGetTexLevelParameteriv(..., GL_TEXTURE_INTENSITY_SIZE, ...) mesa will return a zero size because the actually used format has no intensity channel and as a fallback only the sizes of the red/green channels are checked. Also checking for LA sizes in the allocated texture resolves this problem. v2: Only check alpha channel size and return it (Marek) L and A size are always the same in this case. Fixes (on virgl): ext_framebuffer_multisample-fast-clear GL_ARB_texture_float * Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107832 Signed-off-by:
Gert Wollny <gert.wollny@collabora.com> Reviewed-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 47e01e77)
-
Each query slot is a uint64_t and we were only zeroing half of it. Fixes: 7ec6e4e6 "anv/query: implement multiview interactions" Reviewed-by:
Lionel Landwerlin <lionel.g.landwerlin@intel.com> (cherry picked from commit 07e214f1)
-
No shader-db changes on any Intel platform... which probably explains why no bugs have been bisected to this problem since it landed in Mesa 18.1. :( The commit mentioned below is in 18.2, so 18.1 would need a slightly different fix (due to code refactoring). Signed-off-by:
Ian Romanick <ian.d.romanick@intel.com> Fixes: 77f269bb "i965/fs: Refactor propagation of conditional modifiers from compares to adds" Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com> (reviewed the original patch) Cc: Matt Turner <mattst88@gmail.com> (reviewed the original patch) (cherry picked from commit df9dbc03)
-
When we're mapping temp-resources, we clip the resource to the transfer-box, which means the stride might not be correct any more. So let's update the stride from the temp-resource, and recompute the layer-stride. This fixes crashes when running dEQP with --deqp-gl-config-name=rgba8888d24s8ms4 Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> Fixes: a8987b88 "virgl: add driver for virtio-gpu 3D (v2)" Reviewed-by:
Dave Airlie <airlied@redhat.com> (cherry picked from commit fa5e9f1f)
-
Those operations do not map to actual hardware instructions, therefore those should always be lowered to 32-bit instructions. Fixes: 009c54aa "nv50/ir: Split 64-bit integer MAD/MUL operations" Signed-off-by:
Pierre Moreau <pierre.morrow@free.fr> Reviewed-by:
Karol Herbst <kherbst@redhat.com> Signed-off-by:
Karol Herbst <kherbst@redhat.com> (cherry picked from commit 21b92b34)
-
If we end up never taking the loop that writes ret, we can end up with an uninitialized value, and if we're *really* unlucky, that value can be -1, causing us to go down an error-path instead of a success path. This was obviously not intended, so let's just initialize this to zero. Noticed by Valgrind: Conditional jump or move depends on uninitialised value(s) at 0xBA640A0: virgl_drm_winsys_resource_cache_create (virgl_drm_winsys.c:348) by 0xBA62FCF: virgl_buffer_create (virgl_buffer.c:170) by 0xBA605AC: virgl_resource_create (virgl_resource.c:60) by 0xBCF816F: bufferobj_data (st_cb_bufferobjects.c:344) by 0xBCF816F: st_bufferobj_data (st_cb_bufferobjects.c:390) by 0xBB7E836: vbo_use_buffer_objects (vbo_exec_api.c:1136) by 0xBCFCC6E: st_create_context_priv (st_context.c:414) by 0xBCFD3CD: st_create_context (st_context.c:590) by 0xBBB30CA: st_api_create_context (st_manager.c:896) by 0xB981E76: dri_create_context (dri_context.c:155) by 0xB97BDCE: driCreateContextAttribs (dri_util.c:473) by 0x5288331: dri3_create_context_attribs (dri3_glx.c:309) by 0x5264D64: glXCreateContextAttribsARB (create_context.c:78) Fixes: a8987b88 ("virgl: add driver for virtio-gpu 3D (v2)") Signed-off-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> (cherry picked from commit eaa71858)
-
- Sep 17, 2018
-
-
Apparently for compute there are only 16 instead of the 32 for the graphics path. Fixes dEQP-VK.binding_model.descriptorset_random.sets16.noarray.ubolimitlow.sbolimitlow.imglimitlow.noiub.comp.0 CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit 0dd8189f)
-
Otherwise using 32 user SGPRs would be broken. CC: <mesa-stable@lists.freedesktop.org> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit d97c8925)
-
Fixes the following building error in vc4 build: In file included from external/mesa/src/gallium/drivers/vc4/kernel/vc4_render_cl.c:34: In file included from external/mesa/src/gallium/drivers/vc4/kernel/vc4_drv.h:27: In file included from external/mesa/src/gallium/drivers/vc4/vc4_simulator_validate.h:34: In file included from external/mesa/src/gallium/drivers/vc4/vc4_context.h:39: In file included from external/mesa/src/gallium/drivers/vc4/vc4_cl.h:56: gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h:12:10: fatal error: 'cle/v3d_packet_helpers.h' file not found ^~~~~~~~~~~~~~~~~~~~~~~~~~ 1 error generated. Fixes: 5b102160 ("broadcom/genxml: Introduce a V3D packet/struct decoder.") Cc: "18.2" <mesa-stable@lists.freedesktop.org> Acked-by:
Eric Anholt <eric@anholt.net> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Signed-off-by:
Mauro Rossi <issor.oruam@gmail.com> (cherry picked from commit cc3b99bb)
-
Fixes the following building error: In file included from external/mesa/src/broadcom/cle/v3d_decoder.c:38: In file included from external/mesa/src/broadcom/cle/v3d_packet_helpers.h:29: external/mesa/src/gallium/auxiliary/util/u_math.h:42:10: fatal error: 'pipe/p_compiler.h' file not found ^~~~~~~~~~~~~~~~~~~ 1 error generated. Fixes: 5b102160 ("broadcom/genxml: Introduce a V3D packet/struct decoder.") Cc: "18.2" <mesa-stable@lists.freedesktop.org> Acked-by:
Eric Anholt <eric@anholt.net> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Signed-off-by:
Mauro Rossi <issor.oruam@gmail.com> (cherry picked from commit 9158e0bd)
-
Fixes the following building error, happening when building both intel and broadcom: Gen Header: libmesa_broadcom_genxml_32 <= v3d_packet_v21_pack.h FAILED: gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h /bin/bash -c "python external/mesa/src/broadcom/cle/gen_pack_header.py \ external/mesa/src/broadcom/cle/v3d_packet_v21.xml \ > gen/STATIC_LIBRARIES/libmesa_broadcom_genxml_intermediates/broadcom/cle/v3d_packet_v21_pack.h" Traceback (most recent call last): File "external/mesa/src/broadcom/cle/gen_pack_header.py", line 626, in <module> p = Parser(sys.argv[2]) IndexError: list index out of range header-gen macro is already defined by Intel genxml building rules and the existing header-gen does not have the $(PRIVATE_VER) argument, infact the bash command line logged in the building error is missing exactly $(PRIVATE_VER) argument Renaming the macro as pack-header-gen in src/broadcom/Android.genxml.mk solves the building error, another possible way is to keep the gen rules commands expanded and not use the macros. Fixes: 7f80a9ff ("vc4: Introduce XML-based packet header generation like Intel's.") Cc: "18.2" <mesa-stable@lists.freedesktop.org> Acked-by:
Eric Anholt <eric@anholt.net> Reviewed-by:
Emil Velikov <emil.velikov@collabora.com> Signed-off-by:
Mauro Rossi <issor.oruam@gmail.com> (cherry picked from commit 3341429d)
-
When using Freecad, I was getting intermittent segfaults inside of mesa. I traced it down to this path in st_cb_drawpixels.c where the result of pipe_transfer_map wasn't being checked. In my case, it was returning NULL because nouveau_bo_new returned ENOENT. I'm by no means a mesa developer, but this patch solves the problem for me and seems reasonable enough. v2: Marek - also unmap the PBO and release the texture, and call the make_texture function sooner for less cleanup Cc: 18.1 18.2 <mesa-stable@lists.freedesktop.org> (cherry picked from commit 936e0dcd)
-
Indirect descriptors only need one entry, we don't have to emit a location for every descriptors. Fixes GPU hangs with new CTS: dEQP-VK.binding_model.descriptorset_random.* CC: 18.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 9de062ef)
-
Let say, we first bind a graphics pipeline that needs indirect descriptors sets. The userdata pointers will be emitted at draw time. Then if we bind a compute pipeline that doesn't need any indirect descriptors, the driver will re-emit them for all grpahics stages. To avoid this to happen, just check the bind point type. CC: 18.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 748f4cce)
-
LLVM 6 isn't affected. Fixes GPU hangs with new CTS: dEQP-VK.binding_model.descriptorset_random.* CC: 18.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 063264db)
-
This was wrong for descriptor #0 when all of them are indirect. This is because indirect_offset was 0 and we emitted a "normal" descriptor pointer for nothing. While we are at it remove radv_userdata_info::indirect_offset which is useless. CC: 18.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit aa302059)
-
Bumping to 64 should be safe enough. Fixes some crashes with new CTS: dEQP-VK.binding_model.descriptorset_random.* CC: 18.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit b9f65211)
-
It's actually just the opposite. This fixes the new Sascha conditionalrender demo. CC: 18.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit abdf396c)
-
Otherwise they are not exported. CC: 18.2 <mesa-stable@lists.freedesktop.org> Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> Reviewed-by:
Dave Airlie <airlied@redhat.com> Signed-off-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> (cherry picked from commit d4bf954f)
-
We don't need to wait before drawing to the fake front buffer, as front buffer rendering by definition is allowed to produce artifacts. Fixes hangs in some cases when re-using the fake front buffer, due to it still being busy (i.e. in use for presentation). Cc: mesa-stable@lists.freedesktop.org Bugzilla: https://bugs.freedesktop.org/106404 Bugzilla: https://bugs.freedesktop.org/107757 Tested-by:
Olivier Fourdan <ofourdan@redhat.com> Reviewed-by:
Thomas Hellstrom <thellstrom@vmware.com> (cherry picked from commit aefac10f)
-
- Sep 11, 2018
-
-
Building of 32bit mesa with meson causes linkage issue: "undefined reference to `util_get_process_name'" Fixed by adding link-with mesa_util for xmlconfig primary. v2: Removed '[]', commit message corrected. v3: Reverted changes in gbm and glx libraries. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=107843 Fixes: 2e1e6511 "util: extract get_process_name from xmlconfig.c" Cc: Marek Olšák <marek.olsak@amd.com> Cc: Dylan Baker <dylan@pnwbakers.com> Signed-off-by:
Sergii Romantsov <sergii.romantsov@globallogic.com> Reviewed-by:
Eric Engestrom <eric.engestrom@intel.com> Reviewed-by:
Dylan Baker <dylan@pnwbakers.com> (cherry picked from commit bbe551f3)
-
This fixes the situation where we'd send a shader with just the header and no data. piglit/glsl-max-varyings test was causing this to happen, and the renderer fix was breaking it. v2: drop fprintf Fixes: a8987b88 "virgl: add driver for virtio-gpu 3D (v2)" Reviewed-by:
Erik Faye-Lund <erik.faye-lund@collabora.com> (cherry picked from commit 240af614)
-
Since commit af3685d1 various OpenGL applications regressed on the classic mesa radeon driver. Signed-off-by:
Christopher Egert <cme3000@gmail.com> CC: 18.1 18.2 <mesa-stable@lists.freedesktop.org> Signed-off-by:
Marek Olšák <marek.olsak@amd.com> (cherry picked from commit 51995f69)
-
Reviewed-by:
Jason Ekstrand <jason@jlekstrand.net> Reviewed-by:
Samuel Pitoiset <samuel.pitoiset@gmail.com> CC: 18.2 <mesa-stable@lists.freedesktop.org> (cherry picked from commit f6e09db2)
-
Reviewed-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 6f007857)
-
Acked-by:
Bas Nieuwenhuizen <bas@basnieuwenhuizen.nl> (cherry picked from commit 34a17a48)
-
Cc: 18.2 <mesa-stable@lists.freedesktop.org> Tested-by:
Dieter Nützel <Dieter@nuetzel-hh.de> (cherry picked from commit a5f35aa7)
-
important for debugging Cc: 18.1 18.2 <mesa-stable@lists.freedesktop.org> Tested-by:
Dieter Nützel <Dieter@nuetzel-hh.de> (cherry picked from commit 662db035)
-