Skip to content
Snippets Groups Projects
Commit 7c56a68c authored by José María Casanova Crespo's avatar José María Casanova Crespo Committed by José María Casanova Crespo
Browse files

tgsi_to_nir: only update TGSI properties of the current shader stage


The implementation introduced in "tgsi_to_nir: be careful about not
losing any TGSI properties silently (v2)" updates all the TGSI properties,
but it didn't take into account that the shader_info structure uses a union
to store the different attributes for each shader stage.

Now we only update the attributes if they affect current shader stage,
avoiding to overwrite members of the union that should be overwritten.
This has created hundreds of regressions in v3d.

For example the TGSI_PROPERTY_VS_BLIT_SGPRS_AMD was overwritting the
same position used by TGSI_PROPERY_CS_FIXED_BLOCK_DEPTH.

Fixes: e3003651 ("tgsi_to_nir: be careful about not losing any TGSI properties silently (v2)")

Reviewed-by: default avatarMarek Olšák <marek.olsak@amd.com>
parent 83a63a5b
No related branches found
No related tags found
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment