i965: fix problem with constant out of bounds access (v3)
Okay I now understand why Frank would want to run away, this is my attempt at fixing the CVE out of bounds access to constants outside the range. This attempt converts any illegal constants to constant 0 as per the GL spec, and is undefined behaviour. A future patch should add some debug for users to find this out, but this needs to be backported to stable branches. CVE-2013-1872 v2: drop the last hunk which was a separate fix (now in master). hopefully fix the indentations. v3: don't fail piglit, the whole 8/16 dispatch stuff was over my head, and I spent a while figuring it out, but this one is definitely safe, one piglit pass extra on my Ironlake. NOTE: This is a candidate for stable branches. Signed-off-by:Dave Airlie <airlied@redhat.com> (cherry picked from commit 0677ea06)
Showing
- src/mesa/drivers/dri/i965/brw_fs.cpp 14 additions, 1 deletionsrc/mesa/drivers/dri/i965/brw_fs.cpp
- src/mesa/drivers/dri/i965/brw_fs.h 1 addition, 0 deletionssrc/mesa/drivers/dri/i965/brw_fs.h
- src/mesa/drivers/dri/i965/brw_fs_visitor.cpp 1 addition, 0 deletionssrc/mesa/drivers/dri/i965/brw_fs_visitor.cpp
Loading
Please register or sign in to comment