Skip to content
Snippets Groups Projects
  1. Nov 20, 2011
  2. Nov 18, 2011
  3. Nov 14, 2011
  4. Nov 10, 2011
  5. Nov 09, 2011
  6. Nov 07, 2011
    • Derek Buitenhuis's avatar
      Fix vesa's VBE PanelID interpretation · f0d50cc6
      Derek Buitenhuis authored and Keith Packard's avatar Keith Packard committed
      
      xserver's VESA driver's VBE (Vesa BIOS Extensions) code
      includes a PanelID probe, which can get a monitor's native
      resolution. From this, using CVT formulas, it derives
      horizontal sync rate and a vertical refresh rate ranges.
      
      It however, only derives the upper bounds of the ranges, and
      the lower bounds cannot de derived. By default, they are set
      to hardcoded constants which represent the lowest supported
      resolution: 640x480. The constants in vbe.c however, were
      not actually derived from forulas, but carried over from
      other code from the bad old days, and are not relevant
      to flat panel displays. This caused, for example, EEEPC701's
      panel, with a native resolution of 800x480, to end up with
      a upper bound of the horizontal sync rate that was lower
      than the hardcoded lower bound, which of course broke things.
      
      These numbers have been rederived using both my own CVT tool
      based on xf86CVTMode(), and using the provided 'cvt' tool
      that comes with xserver.
      
      Signed-off-by: default avatarDerek Buitenhuis <derek.buitenhuis@gmail.com>
      Reviewed-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
      Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
      f0d50cc6
  7. Nov 03, 2011
  8. Nov 02, 2011
  9. Oct 31, 2011
    • Aaron Plattner's avatar
      dix: Reinstate GetImage window size check · 8329afa5
      Aaron Plattner authored and Keith Packard's avatar Keith Packard committed
      
      Commit 587c3a2d fixed DoGetImage to
      check windows against their backing drawables, rather than against the
      screen dimensions, to prevent reading outside the bounds of redirected
      windows' backing pixmaps (see bug #22804).  Unfortunately, while
      making that change I also removed the check that the rectangle is
      contained within the bounds of the source window, which is a violation
      of the specification:
      
          If the drawable is a window, the window must be viewable, and it
          must be the case that, if there were no inferiors or overlapping
          windows, the specified rectangle of the window would be fully
          visible on the screen *and wholly contained within the outside
          edges of the window* (or a Match error results). Note that the
          borders of the window can be included and read with this request.
      
          (emphasis mine)
      
      Reinstate the window dimension check, to return BadMatch if the
      GetImage request falls outside the bounds of the window.
      
      Fixes X Test Suite test XGetImage-15:
      
          400|0 15 1 11:05:41|IC Start
          200|0 15 11:05:41|TP Start
          520|0 15 00005146 1 1|VSW5TESTSUITE PURPOSE 15
          520|0 15 00005146 1 2|Assertion XGetImage-15.(A)
          520|0 15 00005146 1 3|When the drawable is a window and the window is viewable
          520|0 15 00005146 1 4|and it is not the case that given there were no inferiors or
          520|0 15 00005146 1 5|overlapping windows the specified rectangle of the window
          520|0 15 00005146 1 6|would be fully visible on the screen and wholly contained
          520|0 15 00005146 1 7|within the outside edges of the window, then a BadMatch
          520|0 15 00005146 1 8|error occurs.
          520|0 15 00005146 1 9|METH: Create window which is not fully visible on the screen.
          520|0 15 00005146 1 10|METH: Call XMapWindow to make sure the window is viewable.
          520|0 15 00005146 1 11|METH: Call XGetImage with rectangle extending beyond edge of screen.
          520|0 15 00005146 1 12|METH: Verify XGetImage return value is null.
          520|0 15 00005146 1 13|METH: Verify that BadMatch error occurred.
          520|0 15 00005146 1 14|METH: Create window which is fully visible on the screen.
          520|0 15 00005146 1 15|METH: Call XMapWindow to make sure the window is viewable.
          520|0 15 00005146 1 16|METH: Call XGetImage with rectangle extending beyond edge of window.
          520|0 15 00005146 1 17|METH: Verify XGetImage return value is null.
          520|0 15 00005146 1 18|METH: Verify that BadMatch error occurred.
          520|0 15 00005146 1 19|REPORT: Got Success, Expecting BadMatch
          520|0 15 00005146 1 20|REPORT: Null image not returned.
          220|0 15 1 11:05:41|FAIL
      
      Signed-off-by: Aaron Plattner's avatarAaron Plattner <aplattner@nvidia.com>
      Reviewed-by: default avatarJeremy Huddleston <jeremyhu@apple.com>
      Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
      8329afa5
  10. Oct 30, 2011
  11. Oct 28, 2011
Loading