- May 05, 2015
-
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
This test can randomly trigger a timeout, depending on how busy the machine is. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
No functional changes Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
- May 04, 2015
-
-
Peter Hutterer authored
Causes an error message in the device_disable_release_tap_n_drag test. When the touchpad is suspended, all touches are ended in tp_clear_state. Since the hovering support was added, this returns the touches to TOUCH_HOVERING, a subsequent tp_handle_state() will turn them back into TOUCH_BEGIN based on BTN_TOUCH and BTN_TOOL_FINGER still being down. Clear the fake touch buttons as well after ending the touches, this way the touch points are reset to TOUCH_NONE as intended. Once we do that we don't need to manually change the tap finger count when releasing taps, we can just let the count reset naturally. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Use tp->nfingers_down as trigger when we have no fingers left on the touchpad and when we should return to idle. If all touchpoints end in the same frame tp->nfingers is 0. Thus when we handle the first tap release we transition to IDLE which now needs to handle (and discard) any touch release events. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Bonobo, Clevo, Galago and Kudu have clickpads and no markings -> enable clickfinger by default. Lemur and Gazelle have physical buttons, no need for extra configuration. https://bugs.freedesktop.org/show_bug.cgi?id=90170 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
This matches the vendor default. Board IDs pulled from modinfo chromeos_laptop, touchpad names from a bit of googling around. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Tested-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
libinput supports lifting a finger during dragging and setting it back down again to continue the drag. Curently the drag timeout is set to DEFAULT_TAP_TIMEOUT. That is to short, when we're dragging the finger needs to have enough time to move from one edge of the touchpad to the other. 180ms is too short for that and causes false timeouts and thus button releases that cancel the drag. Introduce DEFAULT_DRAG_TIMEOUT and set it to 500 ms. Signed-off-by: Velimir Lisec <lisec.velimir@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
The current doubletap timeout was incorrect, it gave the user only 180ms to touch, release, touch, release to recognise a doubletap. But it would also set a timeout on the second release, delaying the button events by 180ms. Instead, re-arm the timer on the second touch down. This gives the user 180ms to release and touch again (or time out). This makes doubletap much more reliable and reduces the delay between the release and the button events arriving since the finger down time is already counted. Same fix for MULTITAP, though we already armed the timer on touch down so we just have to remove the new timer on touch release which did little but delay everything. https://bugs.freedesktop.org/show_bug.cgi?id=90172 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Prep work for the upcoming patch to extend the timeout for tap-and-drag. And switch the tests that rely on it over to the new function. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Reduces the risk of accidental timeouts Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
- May 01, 2015
-
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
- Apr 30, 2015
-
-
Peter Hutterer authored
Resetting a timerfd empties the data on the fd, so if the timer is reset between triggering and us reading it, we may block trying to read it. Since we read events off a device in a loop, a device sending a continuous flow of events may cause the timer to trigger but delay reading it. If one of the events cause e.g. the tap timer to be set, the timerfd may be empty at the time of reading. Suggested-by: Derek Foreman <derekf@osg.samsung.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
We'd rather keep these out of the hands of children. Signed-off-by: Derek Foreman <derekf@osg.samsung.com> Reviewed-by: David Herrmann <dh.herrmann@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Rebuild the same binary but without the special LDFLAG. The event-debug tool is left as-is to allow for easy debugging with gdb, the new tool is now libtool-enabled and can't be run directly in gdb without installing it first. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
libevdev filters the ABS_MT_TRACKING_ID event for a double-touch down like this so we never see this in libinput. We see an error message from libevdev but otherwise this test is a false negative. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Introduced in 6b6f8151, libinput-version.h is in the builddir. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Makes debugging a bit easier when you can just ask users to do that instead of digging around in whatever packaging system they have. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
-
- Apr 28, 2015
-
-
Peter Hutterer authored
If we have a middle button but no wheels, enable on-button scrolling for the middle button by default. This applies e.g. to the Logitech trackball added as new test device here. This makes the separate check for POINTINGSTICK obsolete but I'd rather leave this in to be more explicit about it. https://bugs.freedesktop.org/show_bug.cgi?id=90208 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Instead of excluding the pointing stick devices, disable middle button scrolling on those and run them anyway. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
No need for a separate test suite group here. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Released the wrong touch point, causing warnings: libevdev error in sanitize_event: BUG: Device "litest SynPS/2 Synaptics TouchPad" received a double tracking ID 6 in slot 0. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
- Apr 27, 2015
-
-
Peter Hutterer authored
Almost identical to the one we already had but this one also has ABS_X/Y to mess things up. Update the existing one, no need to add a separate device here. The fake MT touch test needs to be updated now though. A fake MT device may be an absolute device too, so if we use the touch_down() handlers we may generate abs pointer events. That's valid, we only check for no touch events here. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
-
Peter Hutterer authored
Some devices provide abs x/y and rel x/y. We can't know which event the device will send. The Microsoft Surface Type Cover sends relative events, which then crashes libinput when we don't have an accel filter set up. So instead of checking that the device doesn't have ABS_X/Y, check for the device to have REL_X/Y instead. https://bugzilla.redhat.com/show_bug.cgi?id=1206869 Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
-
Peter Hutterer authored
Not sure if any exists, if they do let's see if a user files a bug report first so we know what to do with those (they're most likely buttonsets). Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
-
Peter Hutterer authored
Added in d2842893 but never added to the list of devices so none of the tests ran against it. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
-
Peter Hutterer authored
LITEST_KEYBOARD is the type, LITEST_KEYS is the feature. And this device has buttons, so mark it as such. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
-
Peter Hutterer authored
litest doesn't know how to set this up and we don't need it anyway. Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net> Reviewed-By: Derek Foreman <derekf@osg.samsung.com>
-
Peter Hutterer authored
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Some semi-mt model touchpads have a better accuracy for slot 0 then for slot 1 (they only have 2), so on semi-mt models only use the movement of the touch in slot 0 for 2fg scrolling, rather then the average movement of the 2 touches. This fixes 2fg scrolling being choppy / jumpy in some cases. BugLink: https://bugs.freedesktop.org/show_bug.cgi?id=89683 Signed-off-by: Hans de Goede <hdegoede@redhat.com> Also needed: change the touchpad scroll source test to use more separate events. The current litest semi-mt touch implementation only moves the first touch on every second move. With 5 movements this isn't enough to fill the motion history and generate events, so double it to 10 so we're guaranteed to get scroll events. Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
Those touchpads presents an actual lower resolution that what is advertised. We see some jumps from the cursor due to the big steps in X and Y when we are receiving data. For instance, we receive: E: 13.471932 0003 0000 16366 # EV_ABS / ABS_X 16366 E: 13.471932 0003 0001 9591 # EV_ABS / ABS_Y 9591 E: 13.471932 0000 0000 0000 # ------------ SYN_REPORT (0) ---------- E: 13.479924 0003 0000 16316 # EV_ABS / ABS_X 16316 E: 13.479924 0003 0001 9491 # EV_ABS / ABS_Y 9491 E: 13.479924 0000 0000 0000 # ------------ SYN_REPORT (0) ---------- E: 13.487939 0003 0000 16271 # EV_ABS / ABS_X 16271 E: 13.487939 0003 0001 9403 # EV_ABS / ABS_Y 9403 E: 13.487939 0000 0000 0000 # ------------ SYN_REPORT (0) ---------- -> jumps of ~50 in X in each report, and ~100 for Y. Apply a factor to minimize those jumps at low speed, and try keeping the same feeling as regular touchpads at high speed. It still feels slower but it is usable at least Signed-off-by: Benjamin Tissoires <benjamin.tissoires@gmail.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Tested-by: Vasily Khoruzhick <anarsoul@gmail.com> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-
- Apr 26, 2015
-
-
The mouse can generate key events, so it should be carry that feature bit. Signed-off-by: Derek Foreman <derekf@osg.samsung.com> Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
-