Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • mesa mesa
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 5
    • Issues 5
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 3
    • Merge requests 3
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • GL
  • mesamesa
  • Merge requests
  • !24

st/mesa: fix PBO download for TEXTURE_1D_ARRAY textures

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Yevhenii Kharchenko requested to merge fix/pbo-readpixel-third-coord-1d-array into master Feb 05, 2021
  • Overview 0
  • Commits 595
  • Pipelines 12
  • Changes 602

Fixes 'nir_tex_src_coord' param was provided to NIR 'txf' operation as a vec3 for TEXTURE_1D_ARRAY target, causing an assert. Only following targets require vec3: TEXTURE_2D_ARRAY, TEXTURE_3D, TEXTURE_CUBE, TEXTURE_CUBE_ARRAY. The rest must use vec2.

Packing layer value into Y-coordinate the same way it was done in 'create_fs' in commit 2bf6dfac.

Fixes: a01ad311 ("st/mesa: Add NIR versions of the PBO upload/download shaders. ")

Signed-off-by: Yevhenii Kharchenko yevhenii.kharchenko@globallogic.com

Edited Feb 12, 2021 by Yevhenii Kharchenko
Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: fix/pbo-readpixel-third-coord-1d-array