drm/i915: Fix a lockdep warning at error capture
For some platfroms we use stop_machine version of gen8_ggtt_insert_page/gen8_ggtt_insert_entries to avoid a concurrent GGTT access bug but this causes a circular locking dependency warning: Possible unsafe locking scenario: CPU0 CPU1 ---- ---- lock(&ggtt->error_mutex); lock(dma_fence_map); lock(&ggtt->error_mutex); lock(cpu_hotplug_lock); Fix this by calling gen8_ggtt_insert_page/gen8_ggtt_insert_entries directly at error capture which is concurrent GGTT access safe because reset path make sure of that. v2: Fix rebase conflict and added a comment. Closes: https://gitlab.freedesktop.org/drm/intel/-/issues/5595 Reviewed-by:Gwan-gyeong Mun <gwan-gyeong.mun@intel.com> Suggested-by:
Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by:
Nirmoy Das <nirmoy.das@intel.com> Reviewed-by:
Andrzej Hajda <andrzej.hajda@intel.com> Signed-off-by:
Ramalingam C <ramalingam.c@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20220624110821.29190-1-nirmoy.das@intel.com
Showing
- drivers/gpu/drm/i915/gt/intel_ggtt.c 10 additions, 0 deletionsdrivers/gpu/drm/i915/gt/intel_ggtt.c
- drivers/gpu/drm/i915/gt/intel_gtt.h 9 additions, 0 deletionsdrivers/gpu/drm/i915/gt/intel_gtt.h
- drivers/gpu/drm/i915/gt/uc/intel_uc_fw.c 4 additions, 1 deletiondrivers/gpu/drm/i915/gt/uc/intel_uc_fw.c
- drivers/gpu/drm/i915/i915_gpu_error.c 6 additions, 2 deletionsdrivers/gpu/drm/i915/i915_gpu_error.c
Loading
Please register or sign in to comment