Skip to content
Snippets Groups Projects
  1. May 14, 2015
  2. May 13, 2015
  3. May 12, 2015
  4. May 08, 2015
    • Ralf Habacker's avatar
      reader_init: Initialize all fields of struct DBusTypeReader (CID 54754, 54772, 54773). · 77e1b311
      Ralf Habacker authored
      This patch is based on the fix for 'Field reader.array_len_offset is
      uninitialized'
      
      Reported by Coverity: CID 54754, 54772, 54773: Uninitialized scalar
      variable (UNINIT)
      
      [smcv: also re-order how the class is set when we recurse, so that
      the sub-reader's class doesn't end up NULL]
      
      Bug: https://bugs.freedesktop.org/show_bug.cgi?id=90021
      77e1b311
    • Simon McVittie's avatar
      Merge branch 'dbus-1.8' · 720e3ccb
      Simon McVittie authored
      720e3ccb
    • Simon McVittie's avatar
      Revert "reader_init: Initialize all fields of struct DBusTypeReader (CID 54754, 54772, 54773)." · 480f0182
      Simon McVittie authored
      This reverts commit 21a7873f.
      
      This appears to cause a segfault, presumably resulting from something
      assuming that reader_init() would not reinitialize all fields:
      
       #0  0x00007ffff7b74777 in _dbus_type_reader_get_current_type (reader=reader@entry=0x7fffffffda50) at .../dbus/dbus-marshal-recursive.c:791
       #1  0x00007ffff7b719d0 in _dbus_header_cache_check (header=<optimized out>)
          at .../dbus/dbus-marshal-header.c:209
       #2  0x00007ffff7b719d0 in _dbus_header_cache_check (header=header@entry=0x624658, field=field@entry=6) at .../dbus/dbus-marshal-header.c:250
       #3  0x00007ffff7b72884 in _dbus_header_get_field_basic (header=header@entry=0x624658, field=field@entry=6, type=type@entry=115, value=value@entry=0x7fffffffdbd8) at .../dbus/dbus-marshal-header.c:1365
       #4  0x00007ffff7b7d8c2 in dbus_message_get_destination (message=message@entry=0x624650) at .../dbus/dbus-message.c:3457
       #5  0x00007ffff7b67be6 in _dbus_connection_send_preallocated_unlocked_no_update (connection=connection@entry=0x6236d0, preallocated=0x0,
          preallocated@entry=0x6234c0, message=message@entry=0x624650, client_serial=client_serial@entry=0x7fffffffdcbc)
          at .../dbus/dbus-connection.c:2017
      480f0182
  5. May 06, 2015
Loading