GitLab

The global object is implicit now and the result is an
out arg.

This commit adapts to the new api.

This commit drops usage of JS_AddObjectRoot and switches
the global object over to being wrapped in a JS::Heap
pointer. It stops using JS_DefineObject which no longer
seems to be available, and adds a new JS::FireOnNewGlobalHook
which seems to be required.

seems like it got renamed.

The way args are passed in changed.

This commit does a global search and replace
for OBJECT_TO_JSVAL to JS::ObjectValue()

This commit does a global search and replace
for JSVAL_VOID to JS::UndefinedValue()

This commit does a global search and replace
for JSVAL_NULL to JS::NullValue()

The API got renamed in mozjs31.

It's been gone since mozjs31

This just avoids the potential for security problems down the line.

This commit changes the code to use JS::SetWarningReporter instead
of JS_SetErrorReporter.  The latter, as far as I can tell, is
just a slightly renamed version of the former with the args moved
around a little bit.

JS_SetOptions seems to be replaced with JS::ContextOptionsRef now.
Also, disabling the JIT seems to be three options now instead of just
one.

This is now required

This is now required

it's now part of a behaviors method in CompartmentOptions

Seems like JSContext is the only thing that matters now.

since it doesn't crash if i do that

mozjs no longer has public stub functions that implementers of
JSClass objects are supposed to use.  Instead NULL means
to use the default stub implementations.

Furthermore, the structure has been broken out into a JSClassOps
sub structure now.

This commit adapts the code to the new layout.

This is going to briefly break the build.

Reported by Perter Klotz <peter.klotz99@gmail.com>.

https://bugs.freedesktop.org/show_bug.cgi?id=103144

By Cheng-Chia Tseng <pswo10680@gmail.com>.

https://bugs.freedesktop.org/show_bug.cgi?id=102492

https://bugs.freedesktop.org/show_bug.cgi?id=100764

Signed-off-by: Rui Matos <tiagomatos@gmail.com>

https://bugs.freedesktop.org/show_bug.cgi?id=99741

https://bugs.freedesktop.org/show_bug.cgi?id=99790

I'm trying to keep a relatively standard set around, and the code
there is cleaner than what we had before.

Also, injecting as WARN_CFLAGS rather than changing CFLAGS during
autoconf avoids any surprises from new warnings breaking autoconf
checks.

The autocompartment definition in the previous patches seems to be fine, but
constructing the autocompartment for the lifetime of the global object is probably
a better way to handle this.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

C++ needs explicit casts for many pointer type conversions
For example char * to void * should have a cast. Fix a
number of these cases. Also, correct a white space indentation
error left in the last patch for review clarity.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

Remove mozjs185 and mozjs17 from autoconf and replace them
with mozjs24.

Now that polkitbackendjsauthority is compiling in C++ mode
and the autoconf supports mozjs24, update the module so
that it builds with mozjs24.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

The JSAPI is now a full C++ interface. Convert the polkit
to JavaScript interface module to C++ compilation in order to
support newer versions of spidermonkey.
Signed-off-by: Jeremy Linton <jeremy.linton@arm.com>

The default appears to be to translate all entries. This rule never takes
effect, the path to /action/message and /action/description is wrong (/action
is not a root node). Since we wanted them to be translated, it doesn't matter.

But it also translates all other tags (vendor, allow_any, etc.) and that
causes polkit to be unhappy, it can't handle the various language versions of
"no"

** (polkitd:27434): WARNING **: Unknown PolkitImplicitAuthorization string
'tidak'

Switch to a default of "no" and explicitly include the message and description
strings to be translated.

The patch was modified for PolicyKit by Ondrej Holy <oholy@redhat.com>.

https://bugs.freedesktop.org/show_bug.cgi?id=98366

https://bugs.freedesktop.org/show_bug.cgi?id=97238

gettext can extract strings from and merge them back into xml
file formats, with the help of .its files.

https://bugs.freedesktop.org/show_bug.cgi?id=96940