Fix a critical warning on calling polkit_permission_new_sync with no system bus

984d16e6 · Richard Hughes · Ray Strode · c3646a22 · 984d16e6
Commit 984d16e6 authored Oct 19, 2017 by Richard Hughes Committed by Ray Strode Nov 06, 2018
Hide whitespace changes
Inline Side-by-side

Showing with 7 additions and 4 deletions

src/polkit/polkitpermission.c src/polkit/polkitpermission.c +7 -4

No files found.
--- a/src/polkit/polkitpermission.c
+++ b/src/polkit/polkitpermission.c
@@ -137,10 +137,13 @@ polkit_permission_finalize (GObject *object)
  g_free (permission->tmp_authz_id);
  g_object_unref (permission->subject);

-  g_signal_handlers_disconnect_by_func (permission->authority,
-                                        on_authority_changed,
-                                        permission);
-  g_object_unref (permission->authority);
+  if (permission->authority != NULL)
+    {
+      g_signal_handlers_disconnect_by_func (permission->authority,
+                                            on_authority_changed,
+                                            permission);
+      g_object_unref (permission->authority);
+    }

  if (G_OBJECT_CLASS (polkit_permission_parent_class)->finalize != NULL)
    G_OBJECT_CLASS (polkit_permission_parent_class)->finalize (object);