• David Zeuthen's avatar
    remove misguided action parameters · 81401e16
    David Zeuthen authored
    This feature was introduced with
    
     commit 02a4c510
     http://gitweb.freedesktop.org/?p=PolicyKit.git;a=commit;h=02a4c5101ca4751963f76a0e016d3308389dc2a5
    
    It makes things a lot harder for privilege granting if a feature like
    action parameters are present. Thinking about it, they're not really
    necessary; the parameters should just be encoded in the resource name;
    e.g. with the example given in the commit
    
    > This is useful for letting mechanisms convey information which may be
    > useful in making a decision whether an action is OK. For example,
    > NetworkManager could use this to provide the phone-number parameter
    > with a hypothetical "nm-dialup" action. Then a site or vendor can
    > provide insert
    >
    >  mandatory polkit-run-program.so \
    >     program="/usr/lib/check-dialup-number.sh" privilege="nm-dialup"
    >
    > into /etc/PolicyKit/PolicyKit.conf and have said program check
    >
    >  $POLKIT_ACTION_PARAM_PHONE_NUMBER
    >
    > in that program.
    
    is broken; the right thing here is for a hypothetical NetworkManager
    to pass the dial up connection details as the resource
    
     resource.type = "NetworkManager"
     resource.id = "/org/freedesktop/NM/DialUpConnection/number=555-HOT-CHICKS"
    
    in a well-defined format etc. etc.
    81401e16
polkit-module-run-program.8.in 5.36 KB