1. 11 Jun, 2019 2 commits
    • Thomas Haller's avatar
      all: drop empty first line from sources · 87a73df9
      Thomas Haller authored
        git ls-files -z -- ':(exclude)src/settings/plugins/keyfile/tests/keyfiles' | xargs -0 -n1 sed -i '1 { /^$/d }'
      87a73df9
    • Thomas Haller's avatar
      all: drop emacs file variables from source files · c0e075c9
      Thomas Haller authored
      We no longer add these. If you use Emacs, configure it yourself.
      
      Also, due to our "smart-tab" usage the editor anyway does a subpar
      job handling our tabs. However, on the upside every user can choose
      whatever tab-width he/she prefers. If "smart-tabs" are used properly
      (like we do), every tab-width will work.
      
      No manual changes, just ran commands:
      
          F=($(git grep -l -e '-\*-'))
          sed '1 { /\/\* *-\*-  *[mM]ode.*\*\/$/d }'     -i "${F[@]}"
          sed '1,4 { /^\(#\|--\|dnl\) *-\*- [mM]ode/d }' -i "${F[@]}"
      
      Check remaining lines with:
      
          git grep -e '-\*-'
      
      The ultimate purpose of this is to cleanup our files and eventually use
      SPDX license identifiers. For that, first get rid of the boilerplate lines.
      c0e075c9
  2. 17 Mar, 2017 1 commit
  3. 09 Mar, 2017 1 commit
    • Thomas Haller's avatar
      include: use double-quotes to include our own headers · 831286df
      Thomas Haller authored
      In practice, this should only matter when there are multiple
      header files with the same name. That is something we try
      to avoid already, by giving headers a distinct name.
      
      When building NetworkManager itself, we clearly want to use
      double-quotes for including our own headers.
      But we also want to do that in our public headers. For example:
      
        ./a.c
          #include <stdio.h>
          #include <nm-1.h>
          void main() {
              printf ("INCLUDED %s/nm-2.h\n", SYMB);
          }
      
        ./1/nm-1.h
          #include <nm-2.h>
      
        ./1/nm-2.h
          #define SYMB "1"
      
        ./2/nm-2.h
          #define SYMB "2"
      
      $ cc -I./2 -I./1 ./a.c
      $ ./a.out
      INCLUDED 2/nm-2.h
      
      Exceptions to this are
        - headers in "shared/nm-utils" that include <NetworkManager.h>. These
          headers are copied into projects and hence used like headers owned by
          those projects.
        - examples/C
      831286df
  4. 05 Oct, 2016 1 commit
    • Thomas Haller's avatar
      proxy: cleanup handling of proxy-method · 29b576bd
      Thomas Haller authored
      The numeric value of NM_SETTING_PROXY_METHOD_NONE should be zero,
      as that is the more natural default.
      
      Also, cast all uses of the enum values in g_object_set() to
      (int).
      29b576bd
  5. 04 Oct, 2016 2 commits
    • Atul Anand's avatar
      proxy: remove unnecessary APIs · 812b8774
      Atul Anand authored
      Unnecessary APIs have been removed from nm-setting-proxy, client like
      nm-connection-editor are expected to create a PAC script snippet the load
      the location of file in NM.
      812b8774
    • Atul Anand's avatar
      libnm: API for Proxy Feature · 2a40112e
      Atul Anand authored
      libnm-core has been expanded to include proxy settings which clients
      like nmcli, nm-connection-editor use to configure proxy in PacRunner. It
      offers three modes i.e 'auto', 'manual'and 'none' and accordingly take
      data to configure PacRunner. The modes matches on the PacRunner side too.
      2a40112e