1. 04 Apr, 2022 2 commits
  2. 02 Apr, 2022 5 commits
  3. 01 Apr, 2022 8 commits
    • Thomas Haller's avatar
      core: don't update connection timestamps periodically every 300 seconds · eaba1f30
      Thomas Haller authored
      We store the timestamp when a profile activated the last time to
      "/var/lib/NetworkManager/timestamps". There was also a timer which
      would update the timestamp of activated connections every 300 seconds.
      
      That seems unnecessary, drop it.
      
      For one, waking up every 5 minutes and rewriting a file to disk seems
      undesirable, for example if /var is a device where unnecessary writes
      should be minimized.
      
      Note that we already update the timestamp when a device goes down,
      and of course when it comes up. Updating the timestamp in between seems
      unnecessary.
      
      This reverts commit 60735029 ('core: update timestamp in active
      system connections every 5 mins (bgo #583756)').
      
      An alternative would be to only update the timestamp in memory (so that
      it would appear updated on D-Bus), but delay writing the file until
      something important happens. `nm_key_file_db_*()` already tracks whether
      there are changes ("dirty") and whether it's necessary to write the
      file. It would be possible to track two dirty flags: one that requires
      immediate update, and one that only ensures we will re-write dirty files
      eventually.
      
      See-also: https://bugzilla.gnome.org/show_bug.cgi?id=583756
      
      NetworkManager/NetworkManager!1171
      eaba1f30
    • Thomas Haller's avatar
    • Thomas Haller's avatar
    • Thomas Haller's avatar
      build: drop "check-python-black" check from autotools · 12299ee9
      Thomas Haller authored
      Previously, autotools would detect whether we have "black"
      in the path. And if so, it would check formatting during `make check`.
      
      That's problematic. When I run `./contrib/fedora/rpm/build_clean.sh -w test`
      in certain cases, it would pick up black, but then fail with
      
        Traceback (most recent call last):
          File "/usr/bin/black", line 5, in <module>
            from black import patched_main
          File "/usr/lib/python3.6/site-packages/black.py", line 42, in <module>
            from attr import dataclass, evolve, Factory
        ModuleNotFoundError: No module named 'attr'
        make[3]: *** [Makefile:21658: check-python-black] Error 1
      
      That's an installation error of black, but still, during package build
      there is no need to check the formatting. We could export
      `NMTST_SKIP_PYTHON_BLACK=1` to prevent it, but it's still unnecessary.
      
      We check proper formatting in gitlab-ci. That is enough, it doesn't
      need to run during `make check`. In particular, because `black .`
      takes 1.5 seconds on my machine.
      12299ee9
    • Thomas Haller's avatar
      contrib: add "nm-python-black-format.sh" script · 49b0a92b
      Thomas Haller authored
      This is more for completeness, to go along "nm-code-format.sh"
      script.
      
      Usually it's very simple to run black directly (you may still do that).
      However, black by default only reformats files with ".py" extension.
      So to get all our python files, you'd need to know and explicitly
      select them... or use this script.
      
      Also, `black .` scans the entire source tree, and is rather slow.
      This script knows which files to select and is thus faster.
      49b0a92b
    • Thomas Haller's avatar
      670894b6
    • gogogogi's avatar
      po: update Croatian (hr) translation · 5d440610
      gogogogi authored and Thomas Haller's avatar Thomas Haller committed
      NetworkManager/NetworkManager!1172
      5d440610
    • Beniamino Galvani's avatar
      wwan: re-enable IPv6 once the modem returns a IPv6 configuration · 586afdfc
      Beniamino Galvani authored
      IPv6 gets disabled at the beginning of the activation in
      ip_ifindex_changed_cb(). Enable it again when the modem returns a IPv6
      configuration.
      
      Fixes: 58287cbc ('core: rework IP configuration in NetworkManager using layer 3 configuration')
      
      NetworkManager/NetworkManager#944
      NetworkManager/NetworkManager!1170
      586afdfc
  4. 31 Mar, 2022 1 commit
  5. 30 Mar, 2022 2 commits
    • Thomas Haller's avatar
      po: make update-po · e99d0b33
      Thomas Haller authored
        $ make -C po update-po
      e99d0b33
    • Thomas Haller's avatar
      gitlab-ci: fix archiving build log · 11e8b337
      Thomas Haller authored
      During the test, we `tee` the output to a log file in "/tmp".
      We do that, because the test script cleans the working directory
      several times, so the file cannot reside there.
      
      Afterwards, we need to move the file back into the git-tree, so that
      gitlab can archive it.
      
      Previously that was done by "after_script", but the "after_script" may not
      see the same "/tmp" as the test run ([1]). This needs to be done as part of the
      "script" step.
      
      [1] https://docs.gitlab.com/ee/ci/yaml/#after_script
      11e8b337
  6. 29 Mar, 2022 22 commits