1. 17 Jul, 2017 2 commits
  2. 23 May, 2017 2 commits
  3. 02 May, 2017 1 commit
  4. 26 Apr, 2017 1 commit
    • Thomas Haller's avatar
      device: fix restricting Generic connection by interface-name · bd21d105
      Thomas Haller authored
      NMDeviceGeneric:check_connection_compatible() doesn't check for a
      matching interface name. It relies on the parent implementation to
      do that.
      
      The parent implementation calls nm_manager_get_connection_iface().
      That fails for NM_SETTING_GENERIC_SETTING_NAME, because that one has
      no factory. Maybe this imbalance of having no factory for the Generic device
      is wrong, but usually factories only match a distinct set of device
      types, while the generic factory would handle them all (as last resort).
      
      Without this, activating a generic connection might activate the
      wrong interface.
      
      (cherry picked from commit 3876b10a)
      (cherry picked from commit 753a2cc4)
      (cherry picked from commit bd72919b)
      bd21d105
  5. 24 Apr, 2017 3 commits
  6. 20 Apr, 2017 3 commits
  7. 03 Apr, 2017 4 commits
  8. 24 Mar, 2017 1 commit
    • Lubomir Rintel's avatar
      settings-connection: fix Save() · 1eebc0ca
      Lubomir Rintel authored
      Avoid using new_settings when they are none. Also, don't shortcut when
      the connection hasn't been changed -- let the settings plugin decide if
      it needs to rewrite the connection.
      
      (cherry picked from commit b47340fd)
      (cherry picked from commit 58c9a419)
      1eebc0ca
  9. 23 Mar, 2017 1 commit
  10. 22 Mar, 2017 2 commits
  11. 21 Mar, 2017 2 commits
  12. 20 Mar, 2017 1 commit
  13. 16 Mar, 2017 1 commit
  14. 15 Mar, 2017 1 commit
    • Beniamino Galvani's avatar
      device: fail DHCPv6 if a link-local address is not present · a75d6b8f
      Beniamino Galvani authored
      Instead of throwing an assertion, fail DHCPv6 when a IPv6 link-local
      address is not configured on the device. There are different reasons
      why the assertion may fail: for example the address was removed
      externally; or the device is gone (and thus the platform already
      received the notification of addresses removal) but the device is still
      connecting because its disposal happens in an idle callback.
      
      None of these deserves an assertion, which should only be for
      programming errors.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1432251
      (cherry picked from commit 4987ec40)
      (cherry picked from commit 238fc872)
      a75d6b8f
  15. 09 Mar, 2017 2 commits
  16. 20 Feb, 2017 1 commit
  17. 08 Feb, 2017 2 commits
    • Beniamino Galvani's avatar
      platform: fix detection of primary/secondary addresses · 6913311d
      Beniamino Galvani authored
      ip4_addr_subnets_is_secondary() should fill the list of addresses in
      the same subnet also when returning FALSE, because
      nm_platform_ip4_address_sync() uses it.
      
      Fixes: 2f68a500
      (cherry picked from commit a3479628)
      6913311d
    • Beniamino Galvani's avatar
      platform: fix the order of addition of primary and secondary IPv4 addresses · 8b36e99f
      Beniamino Galvani authored
      nm_platform_ip4_address_sync() tries to apply the new configuration
      with the minimum effort and doesn't delete addresses if they are
      already present on the interface. This can break the ordering, as an
      existing address would be promoted by kernel to primary, even if it
      was last in our configuration.
      
      Add some logic to ensure the correct order of addresses is always
      enforced. This fixes situations like:
      
       # nmcli connection add type ethernet ifname eth0 con-name t \
                              ipv4.method manual \
                              ipv4.addresses "1.1.1.1/24,1.1.1.2/24,1.1.1.5/24"
       # nmcli connection up t
      
        => addresses are applied in the right order:
           inet 1.1.1.1/24 brd 1.1.1.255 scope global eth0
           inet 1.1.1.2/24 brd 1.1.1.255 scope global secondary eth0
           inet 1.1.1.5/24 brd 1.1.1.255 scope global secondary eth0
      
       # nmcli connection mod t ipv4.addresses "1.1.1.5/24,1.1.1.2/24,1.1.1.1/24"
       # nmcli device reapply eth0
      
        => order is wrong:
           inet 1.1.1.2/24 brd 1.1.1.255 scope global eth0
           inet 1.1.1.5/24 brd 1.1.1.255 scope global secondary eth0
           inet 1.1.1.1/24 brd 1.1.1.255 scope global secondary eth0
      Co-Authored-By: Thomas Haller's avatarThomas Haller <thaller@redhat.com>
      (cherry picked from commit 2f68a500)
      8b36e99f
  18. 07 Feb, 2017 2 commits
  19. 06 Feb, 2017 3 commits
  20. 29 Jan, 2017 1 commit
  21. 28 Jan, 2017 2 commits
  22. 19 Jan, 2017 2 commits