Skip to content
GitLab
  1. 05 Nov, 2018 2 commits
  3. 01 Nov, 2018 1 commit
  5. 28 Oct, 2018 6 commits
  7. 27 Oct, 2018 3 commits
    • Alicia Boya García's avatar
      qtmux: round to nearest when computing mehd and tkhd duration · 5fcb7f71
      Alicia Boya García authored and Sebastian Dröge's avatar Sebastian Dröge committed 
      This fixes a bug where in some files mehd.fragment_duration is one unit
less than the actual duration of the fragmented movie, as explained below:

mehd.fragment_duration is computed by scaling the end timestamp of
the last frame of the movie in (in nanoseconds) by the movie timescale.

In some situations, the end timestamp is innacurate due to lossy conversion to
fixed point required by GstBuffer upstream.

Take for instance a movie with 3 frames at exactly 3 fps.

$ gst-launch-1.0 -v videotestsrc num-buffers=3 \
  ! video/x-raw, framerate="(fraction)3/1" \
  ! x264enc \
  ! fakesink silent=false

dts: 999:59:59.333333334,  pts: 1000:00:00.000000000, duration: 0:00:00.333333333
dts: 999:59:59.666666667,  pts: 1000:00:00.666666666, duration: 0:00:00.333333334
dts: 1000:00:00.000000000, pts: 1000:00:00.333333333, duration: 0:00:00.333333333

The end timestamp is calculated by qtmux in this way:

end timestamp = last frame DTS + last frame DUR - first frame DTS =
  = 1000:00:00.000000000 + 0:00:00.333333333 - 999:59:59.333333334 =
  = 0:00:00.999999999

qtmux needs to round this timestamp to the declared movie timescale, which can
ameliorate this distortion, but it's important that round-neareast is used;
otherwise it would backfire badly.

Take for example a movie with a timescale of 30 units/s.

0.999999999 s * 30 units/s = 29.999999970 units

A round-floor (as it was done before this patch) would set fragment_duration to
29 units, amplifying the original distorsion from 1 nanosecond up to 33
milliseconds less than the correct value. The greatest distortion would occur
in the case where timescale = framerate, where an entire frame duration would
be subtracted.

Also, rounding is added to tkhd duration computation too, which
potentially has the same problem.

https://bugzilla.gnome.org/show_bug.cgi?id=793959
      5fcb7f71
    • Marc Leeman's avatar
      udpsrc: print information about bind_error socket error · 827d70da
      Marc Leeman authored and Sebastian Dröge's avatar Sebastian Dröge committed 
      In some cases, a bind error occurs during operation. Printing
the information about the problem is critical for finding the
conflict

https://bugzilla.gnome.org/show_bug.cgi?id=797340
      827d70da
    • Johan Bjäreholt's avatar
      matroska-demux: Fix caps memleak · e736f293
      Johan Bjäreholt authored and Sebastian Dröge's avatar Sebastian Dröge committed 
      https://bugzilla.gnome.org/show_bug.cgi?id=797326
      e736f293
  9. 24 Oct, 2018 5 commits
  11. 22 Oct, 2018 2 commits
  13. 21 Oct, 2018 1 commit
  15. 20 Oct, 2018 2 commits
  17. 19 Oct, 2018 5 commits
  19. 18 Oct, 2018 1 commit
  21. 17 Oct, 2018 2 commits
  23. 16 Oct, 2018 2 commits
  25. 15 Oct, 2018 2 commits
  27. 12 Oct, 2018 2 commits
  29. 11 Oct, 2018 4 commits