1. 04 Jun, 2020 1 commit
    • Yann Dirson's avatar
      dri2: protect glamor_egl_get_driver_name call with proper conditionnal · eab1e0e3
      Yann Dirson authored
      From 1.20.7 build:
      
      aarch64-shadow-linux-libtool: compile:  aarch64-shadow-linux-gcc -fstack-protector-strong -D_FORTIFY_SOURCE=2 -Wformat -Wformat-security -Werror=format-security --sysroot=/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1/recipe-sysroot -DHAVE_CONFIG_H -I. -I../../../../../git/hw/xfree86/drivers/modesetting -I../../../../include -I../../../../../git/hw/xfree86 -I../../../../../git/hw/xfree86/include -I../../../../../git/hw/xfree86/common -I../../../../../git/hw/xfree86/os-support -I../../../../../git/hw/xfree86/os-support/bus -I../../../../../git/os -I../../../../../git/glamor -I../../../../../git/exa -I../../../../../git/dri3 -I../../../../../git/hw/xfree86/drivers/modesetting/../../ddc -I../../../../../git/hw/xfree86/drivers/modesetting/../../dri2 -I../../../../../git/hw/xfree86/drivers/modesetting/../../i2c -I../../../../../git/hw/xfree86/drivers/modesetting/../../modes -I../../../../../git/hw/xfree86/drivers/modesetting/../../parser -I../../../../../git/hw/xfree86/drivers/modesetting/../../ramdac -DHAVE_DIX_CONFIG_H -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wlogical-op -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing -fno-strict-aliasing -D_DEFAULT_SOURCE -D_BSD_SOURCE -DHAS_FCHOWN -DHAS_STICKY_DIR_BIT -I/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1/recipe-sysroot/usr/include/pixman-1 -I/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1/recipe-sysroot/usr/include/freetype2 -I/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1/recipe-sysroot/usr/include/libpng16 -I../../../../../git/include -I../../../../include -I../../../../../git/Xext -I../../../../../git/composite -I../../../../../git/damageext -I../../../../../git/xfixes -I../../../../../git/Xi -I../../../../../git/mi -I../../../../../git/miext/sync -I../../../../../git/miext/shadow -I../../../../../git/miext/damage -I../../../../../git/render -I../../../../../git/randr -I../../../../../git/fb -I../../../../../git/dbe -I../../../../../git/present -fvisibility=hidden -DHAVE_XORG_CONFIG_H -fvisibility=hidden -I/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1/recipe-sysroot/usr/include/libdrm -I/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1/recipe-sysroot/usr/include/libdrm -Wall -Wpointer-arith -Wmissing-declarations -Wformat=2 -Wstrict-prototypes -Wmissing-prototypes -Wnested-externs -Wbad-function-cast -Wold-style-definition -Wdeclaration-after-statement -Wunused -Wuninitialized -Wshadow -Wmissing-noreturn -Wmissing-format-attribute -Wredundant-decls -Wlogical-op -Werror=implicit -Werror=nonnull -Werror=init-self -Werror=main -Werror=missing-braces -Werror=sequence-point -Werror=return-type -Werror=trigraphs -Werror=array-bounds -Werror=write-strings -Werror=address -Werror=int-to-pointer-cast -Werror=pointer-to-int-cast -fno-strict-aliasing -O2 -pipe -g -feliminate-unused-debug-types -fmacro-prefix-map=/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1=/usr/src/debug/xserver-xorg/2_1.20.7-r0.shadow.1 -fdebug-prefix-map=/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1=/usr/src/debug/xserver-xorg/2_1.20.7-r0.shadow.1 -fdebug-prefix-map=/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1/recipe-sysroot= -fdebug-prefix-map=/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1/recipe-sysroot-native= -fcommon -pthread -c ../../../../../git/hw/xfree86/drivers/modesetting/dri2.c  -fPIC -DPIC -o .libs/dri2.o
          ../../../../../git/hw/xfree86/drivers/modesetting/dri2.c: In function 'ms_dri2_screen_init':
          ../../../../../git/hw/xfree86/drivers/modesetting/dri2.c:1089:23: error: implicit declaration of function 'glamor_egl_get_driver_name' [-Werror=implicit-function-declaration]
           1089 |     driver_names[0] = glamor_egl_get_driver_name(screen);
                |                       ^~~~~~~~~~~~~~~~~~~~~~~~~~
          ../../../../../git/hw/xfree86/drivers/modesetting/dri2.c:1089:23: warning: nested extern declaration of 'glamor_egl_get_driver_name' [-Wnested-externs]
          ../../../../../git/hw/xfree86/drivers/modesetting/dri2.c:1089:21: warning: assignment to 'const char *' from 'int' makes pointer from integer without a cast [-Wint-conversion]
           1089 |     driver_names[0] = glamor_egl_get_driver_name(screen);
                |                     ^
          cc1: some warnings being treated as errors
          Makefile:794: recipe for target 'dri2.lo' failed
          make[5]: *** [dri2.lo] Error 1
          make[5]: Leaving directory '/home/gitlab-runner/builds/1b4b81df/0/blade-group/dev/clients/boxes/meta-shadow-os/build/tmp/work/aarch64-shadow-linux/xserver-xorg/2_1.20.7-r0.shadow.1/build/hw/xfree86/drivers/modesetting'
      eab1e0e3
  2. 29 May, 2020 1 commit
    • Olivier Fourdan's avatar
      xwayland: Fix infinite loop at startup · 0430d13c
      Olivier Fourdan authored
      
      
      Mutter recently added headless tests, and when running those tests the
      Wayland compositor runs for a very short time.
      
      Xwayland is spawned by the Wayland compositor and upon startup will
      query the various Wayland protocol supported by the compositor.
      
      To do so, it will do a roundtrip to the Wayland server waiting for
      events it expects.
      
      If the Wayland compositor terminates before Xwayland has got the replies
      it expects, it will loop indefinitely calling `wl_display_roundtrip()`
      continuously.
      
      To avoid that issue, add a new `xwl_screen_roundtrip()` that checks for
      the returned value from `wl_display_roundtrip()` and fails if it is
      negative.
      Signed-off-by: default avatarOlivier Fourdan <ofourdan@redhat.com>
      Reviewed-by: Roman Gilg's avatarRoman Gilg <subdiff@gmail.com>
      Reviewed-by: Jonas Ådahl's avatarJonas Ådahl <jadahl@gmail.com>
      
      (cherry picked from commit 785e5906)
      0430d13c
  3. 22 May, 2020 1 commit
  4. 15 Apr, 2020 1 commit
    • Samuel Thibault's avatar
      dix: do not send focus event when grab actually does not change · 271934db
      Samuel Thibault authored
      c67f2eac
      
       ("dix: always send focus event on grab change") made dix
      always sent events when it's a NotifyGrab or NotifyUngrab, even if
      from == to, because 'from' can just come from a previous XSetInputFocus
      call.
      
      However, when an application calls XGrabKeyboard several times on
      the same window, we are now sending spurious FocusOut+FocusIn with
      NotifyGrab, even if the grab does not actually change. This makes screen
      readers for blind people spuriously emit activity events which disturb
      screen reading workflow when e.g. switching between menus.
      
      This commit avoids calling DoFocusEvents in that precise case, i.e. when
      oldWin is a previous grab and the new grab is the same window.
      Signed-off-by: Samuel Thibault's avatarSamuel Thibault <samuel.thibault@ens-lyon.org>
      Reviewed-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
      (cherry picked from commit 364d6498)
      271934db
  5. 29 Mar, 2020 1 commit
  6. 22 Mar, 2020 2 commits
  7. 18 Mar, 2020 1 commit
  8. 12 Mar, 2020 1 commit
  9. 07 Mar, 2020 2 commits
  10. 02 Mar, 2020 3 commits
  11. 21 Feb, 2020 3 commits
    • Dor Askayo's avatar
      xwayland: clear pixmaps after creation in rootless mode · 94dad4f0
      Dor Askayo authored
      
      
      When a pixmap is created with a backing FBO, the FBO should be cleared
      to avoid rendering uninitialized memory. This could happen when the
      pixmap is rendered without being filled in its entirety.
      
      One example is when a top-level window without a background is
      resized. The pixmap would be reallocated to prepare for more pixels,
      but uninitialized memory would be rendered in the resize offset until
      the client sends a frame that fills these additional pixels.
      
      Another example is when a new top-level window is created without a
      background. Uninitialized memory would be rendered after the pixmap is
      allocated and before the client sends its first frame.
      
      This issue is only apparent in OpenGL implementations that don't zero
      the VRAM of allocated buffers by default, such as RadeonSI.
      Signed-off-by: Dor Askayo's avatarDor Askayo <dor.askayo@gmail.com>
      Closes: xorg/xserver#636
      
      Reviewed-by: Michel Dänzer's avatarMichel Dänzer <mdaenzer@redhat.com>
      (cherry picked from commit 0e9a0c20)
      
      [ Michel Dänzer:
      * Squashed in commit ebf549db
      * Dropped code related to glamor_format, which only exists on master ]
      94dad4f0
    • Michel Dänzer's avatar
      xwayland: Call glamor_block_handler from xwl_screen_post_damage · 0238359b
      Michel Dänzer authored
      In between the two phases introduced by the previous change. This makes
      sure all pending drawing to the new buffers is flushed before they're
      committed to the Wayland server.
      (cherry picked from commit a542224e)
      0238359b
    • Michel Dänzer's avatar
      xwayland: Split up xwl_screen_post_damage into two phases · a93bce6b
      Michel Dänzer authored
      
      
      The first phase sets the new surface properties for all damaged
      windows, then the second phase commits all surface updates.
      
      This is preparatory for the next change, there should be no observable
      change in behaviour (other than the order of Wayland protocol
      requests).
      Reviewed-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
      (cherry picked from commit f88d9b1f)
      a93bce6b
  12. 19 Feb, 2020 1 commit
  13. 10 Feb, 2020 5 commits
  14. 06 Feb, 2020 5 commits
  15. 14 Jan, 2020 2 commits
  16. 13 Jan, 2020 8 commits
  17. 09 Jan, 2020 1 commit
  18. 18 Dec, 2019 1 commit