- 16 Apr, 2021 6 commits
-
-
Martin Roukala authored
-
Martin Roukala authored
Fixes: bf105472
-
Martin Roukala authored
-
Martin Roukala authored
We just ran in a regression, because pre-merge testing could not be used to test the creation of the container. So let's fix that!
-
Martin Roukala authored
I don't like the current solution, but we'll revisit it later as part of a potential conversion to CI templates.
-
Martin Roukala authored
With this change, we add an `end` field to the MembershipPeriod class, to be able to say when members of the previous period will stop receiving new emails. Closes: #41
-
- 28 Mar, 2021 9 commits
-
-
Martin Roukala authored
Validation already exists to prevent that, but this makes it easier for users to rank the different options, without fearing giving more points to one option. Closes: #38
-
Martin Roukala authored
Closes: #28
-
Martin Roukala authored
Rather than creating a new function every time we add stuff, just create one to rule them all.
-
Martin Roukala authored
Having links that you cannot click are confusing, and expecting users to see the "Thanks for voting!" text added to the title of the link was pretty bad. Instead, this commit adds "(voted)" on the side, and removes the href on the link, which leaves the decription open, but hides the clicking cursor. Suggested-by: Emil Velikov Closes: #37
-
Martin Roukala authored
-
Martin Roukala authored
The new solution isn't particularly pretty either, but it is less confusing.
-
Martin Roukala authored
Drop testing on python 3.5, as it is unsupported by django 3.0
-
Martin Roukala authored
-
Martin Roukala authored
We limit ourselves to django 2.2.19 for now, as django 3.0 regresses some tests. Closes: #42
-
- 13 Mar, 2021 1 commit
-
-
Martin Roukala authored
-
- 23 Mar, 2020 1 commit
-
-
Martin Roukala authored
As per section 2.5 of the X.Org Bylaws, members have affiliations, not employers. This commit fixes this oversight! Reported-by: Pekka Paalanen Closes: #39
-
- 11 Apr, 2019 5 commits
-
-
Martin Roukala authored
This works without them as long as the string is 1 character-long... which is why the unit test was fine with it!
-
Martin Roukala authored
-
Martin Roukala authored
-
Martin Roukala authored
-
Martin Roukala authored
Upon parsing the result coming from the user, we convert the DB ids we sent to the user into actual DB-backed python objects. Unfortunately, the _get_objects() helper that performs this conversion did not return the objects in the order the user ranked them, but instead the order in which the objects had been created in the DB... Not only was this oversight was then not caught by unit testing, because test_valid_form() was concentrating on verifying that we were getting the right objects rather than checking the order, but this also escaped our multiple mock election attempts... I guess humans like to rank people based on the number next to them... The fix is simple, albeit inefficient: make one query per option, in the order the user gave us the list. On the unit test side, multiple combinations of ranks are now tested to prevent such regressions to ever happen again. Finally, for the new manual validation plan, the idea will be to use a theme and make sure people will not all order things in different way. Appologies for the mess this caused...
-
- 30 Mar, 2019 1 commit
-
-
Martin Roukala authored
Closes #32
-
- 28 Jan, 2019 1 commit
-
-
Martin Roukala authored
Closes #18.
-
- 27 Jan, 2019 1 commit
-
-
Martin Roukala authored
-
- 26 Jan, 2019 4 commits
-
-
Martin Roukala authored
Good that it got caught by gitlab's CI! Fixes: 818e65b1
-
Martin Roukala authored
-
Martin Roukala authored
Closes #19.
-
Martin Roukala authored
Closes #29.
-
- 25 Jan, 2019 3 commits
-
-
Eric Engestrom authored
-
Eric Engestrom authored
-
Martin Roukala authored
This implements part of #23.
-
- 24 Jan, 2019 4 commits
-
-
Martin Roukala authored
No idea why I could not manage to use them before...
-
Martin Roukala authored
Closes #24.
-
Martin Roukala authored
-
Martin Roukala authored
This was the defautl behaviour, I should have kept it!
-
- 22 Jan, 2019 2 commits
-
-
Martin Roukala authored
-
Martin Roukala authored
This simplifies deployment.
-
- 20 Jan, 2019 2 commits
-
-
Martin Roukala authored
-
Martin Roukala authored
-