Commit 71703e4e authored by rpm-build's avatar rpm-build Committed by Peter Hutterer

xfree86: ensure the readlink buffer is null-terminated

Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: default avatarDave Airlie <airlied@redhat.com>
parent ff91c696
Pipeline #5854 passed with stage
in 2 minutes and 33 seconds
...@@ -331,12 +331,12 @@ fbdev_open(int scrnIndex, const char *dev, char **namep) ...@@ -331,12 +331,12 @@ fbdev_open(int scrnIndex, const char *dev, char **namep)
/* only touch non-PCI devices on this path */ /* only touch non-PCI devices on this path */
{ {
char buf[PATH_MAX]; char buf[PATH_MAX] = {0};
char *sysfs_path = NULL; char *sysfs_path = NULL;
char *node = strrchr(dev, '/') + 1; char *node = strrchr(dev, '/') + 1;
if (asprintf(&sysfs_path, "/sys/class/graphics/%s", node) < 0 || if (asprintf(&sysfs_path, "/sys/class/graphics/%s", node) < 0 ||
readlink(sysfs_path, buf, sizeof(buf)) < 0 || readlink(sysfs_path, buf, sizeof(buf) - 1) < 0 ||
strstr(buf, "devices/pci")) { strstr(buf, "devices/pci")) {
free(sysfs_path); free(sysfs_path);
close(fd); close(fd);
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment