Skip to content
Commit 0a9415cf authored by Adam Jackson's avatar Adam Jackson 🎧 Committed by Adam Jackson
Browse files

glamor_egl: Don't initialize on llvmpipe



Mesa started supporting GL_OES_EGL_image on llvmpipe in 17.3, after this
commit:

    commit bbdeddd5fd0b797e1e281f058338b3da4d98029d
    Author: Gurchetan Singh <gurchetansingh@chromium.org>
    Date:   Tue Aug 1 14:49:33 2017 -0700

        st/dri: add drisw image extension

That's pretty cool, but it means glamor now thinks it can initialize on
llvmpipe. This is almost certainly not what anyone wants, as glamor on
llvmpipe is pretty much uniformly slower than fb.

This fixes both Xorg and Xwayland to refuse glamor in such a setup.
Xephyr is left alone, both because glamor is not the default there and
because Xephyr+glamor+llvmpipe is one of the easier ways to get xts to
exercise glamor.

The (very small) downside of this change is that you lose DRI3 support.
This wouldn't have helped you very much (since an lp glamor blit is
slower than a pixman blit), but it would eliminate the PutImage overhead
for llvmpipe's glXSwapBuffers. A future change should add DRI3 support
for the fb-only case.

Reviewed-by: default avatarEric Anholt <eric@anholt.net>
Signed-off-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
parent feca61cd
Loading
Loading
Loading
Pipeline #5012 passed with stage
in 1 minute and 33 seconds
Loading
  • Adam Jackson 🎧 @ajax

    mentioned in merge request !37 (merged)

    ·

    mentioned in merge request !37 (merged)

    Toggle commit list
  • Adam Jackson 🎧 @ajax

    mentioned in commit af151895

    ·

    mentioned in commit af151895

    Toggle commit list
  • Chia-I Wu @olv

    mentioned in merge request mesa/mesa!15479 (closed)

    ·

    mentioned in merge request mesa/mesa!15479 (closed)

    Toggle commit list
  • The (very small) downside of this change is that you lose DRI3 support.
    This wouldn't have helped you very much (since an lp glamor blit is
    slower than a pixman blit), but it would eliminate the PutImage overhead
    for llvmpipe's glXSwapBuffers. A future change should add DRI3 support
    for the fb-only case.

    Do you means we need A future change should add DRI3 support for the fb-only case. @olv, @ajax How to add DRI3 support for the fb-only case?

  • Olivier Fourdan 🛠 @ofourdan

    mentioned in merge request !956 (merged)

    ·

    mentioned in merge request !956 (merged)

    Toggle commit list
  • Ivan Melnikov @iv-m

    mentioned in merge request !1033 (merged)

    ·

    mentioned in merge request !1033 (merged)

    Toggle commit list
  • Ivan Melnikov @iv-m

    mentioned in commit b2b3f67e

    ·

    mentioned in commit b2b3f67e

    Toggle commit list
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment