Skip to content
GitLab
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • xserver xserver
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 921
    • Issues 921
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 119
    • Merge requests 119
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages and registries
    • Packages and registries
    • Container Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorgxorg
  • xserverxserver
  • Merge requests
  • !418

shm: Don't try to put a whole bunch of clipped XY image contents.

  • Review changes

  • Download
  • Email patches
  • Plain diff
Closed Emma Anholt requested to merge anholt/xserver:shmputimage-fix into master Apr 03, 2020
  • Overview 2
  • Commits 1
  • Pipelines 1
  • Changes 1

sw and sh are smaller than w and h, and our temporary pixmap is only sw by sh, and we copy out an area of sw by sh. There's no need to go asking the driver to putimage w by h, and glamor acceleration tripped over this by making a temporary of the fbPutImage results of size w by h, without running it through the clip first.

Assignee
Assign to
Reviewers
Request review from
Time tracking
Source branch: shmputimage-fix