Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
xserver
xserver
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 892
    • Issues 892
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 86
    • Merge Requests 86
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • xorg
  • xserverxserver
  • Issues
  • #4

Closed
Open
Opened Oct 18, 2018 by Andreas Fett@afettContributor

XDMCP: "-from" option broken for IPv6

In os/xdmcp.c the funktion static void get_xdmcp_sock(void) uses xdmcpSocket6 = socket(AF_INET6, SOCK_DGRAM, 0) for IPv6 and xdmcpSocket = socket(AF_INET, SOCK_DGRAM, 0) for IPv4. When using the "-from" option with an Ipv6 address - the manpage requires only, that it can be resolved with gethostbyname(3) - a bind(2) is attempted using xdmcpSocket instead of xdmcpSocket6 which must fail.

I suggest either adding a "-from6" option or selecting the appropriate socket filedescriptor based on the address family of the argument to "-from".

If you can tell me which one you'd prefer I'll prepare a patch.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: xorg/xserver#4