Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
xserver
xserver
  • Project overview
    • Project overview
    • Details
    • Activity
    • Releases
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 893
    • Issues 893
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Merge Requests 87
    • Merge Requests 87
  • CI / CD
    • CI / CD
    • Pipelines
    • Jobs
    • Schedules
  • Operations
    • Operations
    • Incidents
    • Environments
  • Packages & Registries
    • Packages & Registries
    • Container Registry
  • Analytics
    • Analytics
    • CI / CD
    • Repository
    • Value Stream
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
  • xorg
  • xserverxserver
  • Issues
  • #373

Closed
Open
Opened Sep 25, 2008 by Bugzilla Migration User@bugzilla-migration

Is TS_Raw defined with the correct values?

Submitted by Kevin Day

Assigned to Xorg Project Team

Link to original bug (#17778)

Description

TS_Raw and similar were removed from xinputproto at some point. This later caused a problem. This problem was fixed by having the TS_Raw and similar put back into the xorg server.

Namely: xorg-server 1.5.1/hw/xfree86/common/xf86Xinput.h Lines: 88->90 code:

/* Stupid API backwards-compatibility. */ #define TS_Raw 60 #define TS_Scaled 61

Are the values 60 & 61 correct? Please defend/explain why they are 60 and 61. Because when I look at: inputproto-1.3.2/XI.h Lines: 207->212 where the TS_Raw values were originally defined as:

/* Merged from Metrolink tree for XINPUT stuff / #define TS_Raw 57 #define TS_Scaled 58 #define SendCoreEvents 59 #define DontSendCoreEvents 60 / End of merged section */

Here they are defined as 57 and 58.

I cannot see the new values as correct, especially when looking at the bottom of xorg-server-1.5.2's xf86Xinput.h on lines 211->213, the following exists:

/* Legacy hatred */ #define SendCoreEvents 59 #define DontSendCoreEvents 60

Notice that here, TS-Raw is defined as the same number as DontSendCoreEvents Looking at the old XI.h, DontSendCoreEvents and TS_Raw are grouped together AND are different numbers.

This problem effects xorg-server 1.4. As far as xorg-server 1.3, the TS_Raw is missing entirely and that was when the TS_Raw is missing problem was noticed. See bug: 10262

Version: 7.4 (2008.09)

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: xorg/xserver#373