Skip to content

refactor: use dixDestroyPixmap() instead of direct driver proc calls

As preparation for lightening up the screen proc wrapping jungle (*1), some major blockers need to be cleaned up - one of them is many sites directly calling into the raw ScreenRec's DestroyPixmap() proc vector, instead of calling the corresponding dix function: dixDestroyPixmap().

Therefore, all call sites need to be fixed to call dixDestroyPixmap() - including drivers.

*1) https://lists.x.org/archives/xorg-devel/2024-September/059319.html

The future plan is (after this issue is solved):

  • decouple extension specific destruction logic from the wrapping chain
  • call it only when the pixmap is really destroyed and not just unref'ed (so extensions don't need to check that anymore)

Even though, dixDestroyPixmap() historically wasn't designed specifically for that, it's already there (and exported) for decades and it's current semantics suit the job well (the extra XID parameter is ignored anyways). Thus we can easily refit drivers to use it, w/o any ABI break for both old and new Xserver versions.

Dependencies / partial work items:

Current status

Context

  • parent story: #1755 - refactor: don't wrap ScreenRec procs
Edited by Enrico Weigelt, metux IT consult .
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information