-
hw/xwayland/xwayland-glamor-gbm.c:38:10: fatal error: 'linux/dma-buf.h' file not found 38 | #include <linux/dma-buf.h> | ^~~~~~~~~~~~~~~~~ Fixes: 3df236a3 ("xwayland: add functions to import and export dma-buf implicit fences") Part-of: <xorg/xserver!1481>
f0748b05 -
There are a number of regressions and hard to reproduce issues that find their roots in this change, so revert it until those can be ironed out some more. This reverts commit 4bb1f976. Closes: xorg/xserver#1655 Closes: xorg/xserver#1656 Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> Part-of: <xorg/xserver!1457>
a65bb848 -
Balló György authored
Instead of thowing fatal error on GLSL link failure, fall back to software rendering. This allows using Glamor on systems with limited hardware resources (such as i915). Part-of: <!1173>
007e98b1 -
Fixes leaks: ==13712== 144 bytes in 1 blocks are definitely lost in loss record 4,827 of 7,462 ==13712== at 0x48459F3: calloc (vg_replace_malloc.c:1340) ==13712== by 0x49BE94D: drmDeviceAlloc (xf86drm.c:4072) ==13712== by 0x49BFAC9: drmProcessPciDevice (xf86drm.c:4104) ==13712== by 0x49BFAC9: process_device (xf86drm.c:4508) ==13712== by 0x49C35FB: drmGetDeviceFromDevId (xf86drm.c:4670) ==13712== by 0x1AD370: xwl_dmabuf_feedback_main_device (xwayland-dmabuf.c:477) ==13712== by 0x53C03FD: ffi_call_unix64 (unix64.S:104) ==13712== by 0x53BF70C: ffi_call_int (ffi64.c:673) ==13712== by 0x53BFEE2: ffi_call (ffi64.c:710) ==13712== by 0x49AC920: wl_closure_invoke (connection.c:1025) ==13712== by 0x49A8C08: dispatch_event.isra.0 (wayland-client.c:1631) ==13712== by 0x49AA5AB: dispatch_queue (wayland-client.c:1777) ==13712== by 0x49AA5AB: wl_display_dispatch_queue_pending (wayland-client.c:2019) ==13712== by 0x49AAB5E: wl_display_roundtrip_queue (wayland-client.c:1403) ==13712== 576 bytes in 4 blocks are definitely lost in loss record 6,289 of 7,462 ==13712== at 0x48459F3: calloc (vg_replace_malloc.c:1340) ==13712== by 0x49BE94D: drmDeviceAlloc (xf86drm.c:4072) ==13712== by 0x49BFAC9: drmProcessPciDevice (xf86drm.c:4104) ==13712== by 0x49BFAC9: process_device (xf86drm.c:4508) ==13712== by 0x49C35FB: drmGetDeviceFromDevId (xf86drm.c:4670) ==13712== by 0x1AD583: xwl_dmabuf_feedback_main_device (xwayland-dmabuf.c:477) ==13712== by 0x1AD583: xwl_window_dmabuf_feedback_main_device (xwayland-dmabuf.c:691) ==13712== by 0x53C03FD: ffi_call_unix64 (unix64.S:104) ==13712== by 0x53BF70C: ffi_call_int (ffi64.c:673) ==13712== by 0x53BFEE2: ffi_call (ffi64.c:710) ==13712== by 0x49AC920: wl_closure_invoke (connection.c:1025) ==13712== by 0x49A8C08: dispatch_event.isra.0 (wayland-client.c:1631) ==13712== by 0x49AA5AB: dispatch_queue (wayland-client.c:1777) ==13712== by 0x49AA5AB: wl_display_dispatch_queue_pending (wayland-client.c:2019) ==13712== by 0x1A1842: xwl_read_events (xwayland-screen.c:566) ==13712== by 0x1A1842: xwl_read_events (xwayland-screen.c:553) Fixes: 6f0b9dee ("xwayland: use drmDevice to compare DRM devices") Part-of: <xorg/xserver!1484>
82d3b8ff -
xwl_dmabuf_feedback_tranche_target_device always allocates a new drmDevice for xwl_feedback->tmp_tranche.drm_dev, so the pointers are never equal here. Fixes: 6f0b9dee ("xwayland: use drmDevice to compare DRM devices") v2: * Flip order of checks, so drmDevicesEqual is called only if the supports_scanout flags match. Part-of: <xorg/xserver!1484>
4dc7e998 -
Fixes leak: ==15672== 60 bytes in 1 blocks are definitely lost in loss record 3,803 of 8,127 ==15672== at 0x4840718: malloc (vg_replace_malloc.c:392) ==15672== by 0x2F2698: XNFreallocarray (alloc.c:55) ==15672== by 0x1ADAA9: xwl_dmabuf_get_formats_for_device (xwayland-dmabuf.c:207) ==15672== by 0x1ADAA9: xwl_glamor_get_formats (xwayland-dmabuf.c:248) ==15672== by 0x303D86: cache_formats_and_modifiers (dri3_screen.c:176) ==15672== by 0x303D86: dri3_get_supported_modifiers (dri3_screen.c:229) ==15672== by 0x30331A: proc_dri3_get_supported_modifiers (dri3_request.c:389) ==15672== by 0x217B6B: Dispatch (dispatch.c:550) ==15672== by 0x21B9A0: dix_main (main.c:276) ==15672== by 0x51086C9: (below main) (libc_start_call_main.h:58) Fixes: a42992a4 ("dri3: rework format/modifier caching") Part-of: <xorg/xserver!1484>
3b6b88c1 -
In xwl_source_validate(), the actual box wasn't updated, so we would possibly copy several times the same first box. Signed-off-by:
Olivier Fourdan <ofourdan@redhat.com> Reviewed-by:
Michel Dänzer <mdaenzer@redhat.com> Fixes: aa05f38f - xwayland: Add SourceValidate hook Part-of: <xorg/xserver!1485>
385226bd
- dri3/dri3_screen.c 4 additions, 1 deletiondri3/dri3_screen.c
- glamor/glamor.c 10 additions, 33 deletionsglamor/glamor.c
- glamor/glamor_core.c 3 additions, 2 deletionsglamor/glamor_core.c
- glamor/glamor_gradient.c 25 additions, 11 deletionsglamor/glamor_gradient.c
- glamor/glamor_priv.h 3 additions, 4 deletionsglamor/glamor_priv.h
- glamor/glamor_program.c 2 additions, 1 deletionglamor/glamor_program.c
- glamor/glamor_render.c 34 additions, 5 deletionsglamor/glamor_render.c
- hw/xwayland/xwayland-dmabuf.c 5 additions, 2 deletionshw/xwayland/xwayland-dmabuf.c
- hw/xwayland/xwayland-glamor-gbm.c 2 additions, 0 deletionshw/xwayland/xwayland-glamor-gbm.c
- hw/xwayland/xwayland-glamor.c 0 additions, 110 deletionshw/xwayland/xwayland-glamor.c
- hw/xwayland/xwayland-screen.h 0 additions, 2 deletionshw/xwayland/xwayland-screen.h
- hw/xwayland/xwayland-window.c 1 addition, 0 deletionshw/xwayland/xwayland-window.c