1. 23 Jan, 2015 1 commit
    • Adam Jackson's avatar
      dix: make RegionInit legal C++ · bb23fbf5
      Adam Jackson authored
      The CVE fix in:
      
          commit 97015a07
          Author: Alan Coopersmith <alan.coopersmith@oracle.com>
          Date:   Wed Jan 22 22:37:15 2014 -0800
      
              dix: integer overflow in RegionSizeof() [CVE-2014-8092 3/4]
      
      offended the C++ demons:
      
      ../../include/regionstr.h:147:45: error: invalid conversion from 'void*' to
      'pixman_region16_data_t* {aka pixman_region16_data*}' [-fpermissive]
      
      Normally this isn't a problem, because around here we have the sense and
      common decency to not use C++, but this does make tigervnc fail to build,
      which is a little rude of us.
      Signed-off-by: Adam Jackson's avatarAdam Jackson <ajax@redhat.com>
      Reviewed-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      Signed-off-by: Keith Packard's avatarKeith Packard <keithp@keithp.com>
      bb23fbf5
  2. 09 Dec, 2014 1 commit
  3. 12 Nov, 2014 1 commit
  4. 31 Oct, 2013 1 commit
  5. 21 Mar, 2012 1 commit
    • Keith Packard's avatar
      Introduce a consistent coding style · 9838b703
      Keith Packard authored
      This is strictly the application of the script 'x-indent-all.sh'
      from util/modular. Compared to the patch that Daniel posted in
      January, I've added a few indent flags:
      
      	-bap
      	-psl
      	-T PrivatePtr
      	-T pmWait
      	-T _XFUNCPROTOBEGIN
      	-T _XFUNCPROTOEND
      	-T _X_EXPORT
      
      The typedefs were needed to make the output of sdksyms.sh match the
      previous output, otherwise, the code is formatted badly enough that
      sdksyms.sh generates incorrect output.
      
      The generated code was compared with the previous version and found to
      be essentially identical -- "assert" line numbers and BUILD_TIME were
      the only differences found.
      
      The comparison was done with this script:
      
      dir1=$1
      dir2=$2
      
      for dir in $dir1 $dir2; do
      	(cd $dir && find . -name '*.o' | while read file; do
      		dir=`dirname $file`
      		base=`basename $file .o`
      		dump=$dir/$base.dump
      		objdump -d $file > $dump
      	done)
      done
      
      find $dir1 -name '*.dump' | while read dump; do
      	otherdump=`echo $dump | sed "s;$dir1;$dir2;"`
      	diff -u $dump $otherdump
      done
      Signed-off-by: Keith Packard's avatarKeith Packard <keithp@keithp.com>
      Acked-by: Daniel Stone's avatarDaniel Stone <daniel@fooishbar.org>
      Acked-by: Alan Coopersmith's avatarAlan Coopersmith <alan.coopersmith@oracle.com>
      9838b703
  6. 23 Apr, 2011 1 commit
    • Søren Sandmann Pedersen's avatar
      Add RegionInitBoxes(), and fix some buggy callers of RegionInit(). · 61a92a78
      Søren Sandmann Pedersen authored
      The interface to RegionInit():
      
          RegionInit (RegionPtr pReg, BoxPtr rect, int size);
      
      is very confusing because it doesn't take a list of boxes, it takes
      *one* box, but if that box is NULL, it initializes an empty region
      with 'size' rectangles preallocated.
      
      Most callers of this function were correctly passing either NULL or
      just one box, but there were three confused cases, where the code
      seems to expect a region to be created from a list of boxes.
      
      This patch adds a new function RegionInitBoxes() and fixes those
      instances to call that instead.
      
      And yes, the pixman function to initialize a region from a list of
      boxes is called init_rects() because pixman is also awesome.
      
      V2: Make RegionInitBoxes() return a Bool indicating whether the call
          succeeded, and fix the callers to check this return value.
      Reviewed-by: Keith Packard's avatarKeith Packard <keithp@keithp.com>
      Signed-off-by: default avatarSøren Sandmann <ssp@redhat.com>
      61a92a78
  7. 01 Mar, 2011 1 commit
  8. 06 Jun, 2010 4 commits
  9. 12 May, 2010 1 commit
  10. 03 Dec, 2008 1 commit
    • Paulo Cesar Pereira de Andrade's avatar
      Rework symbol visibility for easier maintenance · 49f77fff
      Paulo Cesar Pereira de Andrade authored
        Save in a few special cases, _X_EXPORT should not be used in C source
      files. Instead, it should be used in headers, and the proper C source
      include that header. Some special cases are symbols that need to be
      shared between modules, but not expected to be used by external drivers,
      and symbols that are accessible via LoaderSymbol/dlopen.
      
        This patch also adds conditionally some new sdk header files, depending
      on extensions enabled. These files were added to match pattern for
      other extensions/modules, that is, have the headers "deciding" symbol
      visibility in the sdk. These headers are:
      o Xext/panoramiXsrv.h, Xext/panoramiX.h
      o fbpict.h (unconditionally)
      o vidmodeproc.h
      o mioverlay.h (unconditionally, used only by xaa)
      o xfixes.h (unconditionally, symbols required by dri2)
      
        LoaderSymbol and similar functions now don't have different prototypes,
      in loaderProcs.h and xf86Module.h, so that both headers can be included,
      without the need of defining IN_LOADER.
      
        xf86NewInputDevice() device prototype readded to xf86Xinput.h, but
      not exported (and with a comment about it).
      49f77fff
  11. 17 Jul, 2008 1 commit
    • Daniel Stone's avatar
      Dead code removal · 446fe9ee
      Daniel Stone authored
      Remove a whole bunch of code that was never built, be it entire files or
      just dead ifdefs.
      446fe9ee
  12. 11 Mar, 2008 1 commit
    • Kristian Høgsberg's avatar
      Silence REGION_INIT() warning. · c7536f4b
      Kristian Høgsberg authored
      Evaluating the address of a BoxRec as a boolean gives this warning:
      
        i830_driver.c:2317: warning: the address of 'ScreenBox' will always
        evaluate as 'true'
      
      which is pretty annoying.  This patch compares the address to NULL to
      avoid the pointer->bool conversion and gets rid of the warning.  Seems
      like a lame hack, but the warning is worse.
      c7536f4b
  13. 15 May, 2007 2 commits
  14. 08 Nov, 2006 1 commit
    • Daniel Stone's avatar
      dix/mi: still more warning fixes · c3ea1f7d
      Daniel Stone authored
      Fix up prototypes for PrintChildren and PrintWindowTree in the dix.
      Make miPrintRegion be unconditionally defined, and move the prototype into
      regionstr.h.
      Change a bunch of ScreenPtr pScreen = foo; to
      ScreenPtr pScreen; pScreen = foo; in window.c, so we avoid unused variable
      references (as inline REGION_* doesn't reference pScreen).
      c3ea1f7d
  15. 21 Jul, 2006 1 commit
  16. 28 Mar, 2006 1 commit
  17. 24 Aug, 2005 1 commit
  18. 03 Jul, 2005 1 commit
  19. 01 Jul, 2005 1 commit
  20. 25 Jun, 2005 1 commit
  21. 29 Jul, 2004 1 commit
  22. 04 May, 2004 1 commit
  23. 23 Apr, 2004 1 commit
  24. 25 Mar, 2004 2 commits
  25. 14 Mar, 2004 1 commit
  26. 05 Mar, 2004 1 commit
  27. 03 Mar, 2004 1 commit
  28. 26 Feb, 2004 2 commits
  29. 20 Dec, 2003 1 commit
  30. 19 Dec, 2003 1 commit
  31. 06 Dec, 2003 1 commit
  32. 04 Dec, 2003 1 commit
  33. 30 Nov, 2003 1 commit
  34. 29 Nov, 2003 1 commit