Skip to content
  • Alan Coopersmith's avatar
    int10: wrap entire V_ADDR_R* macros in parens for safer expansion · e5386011
    Alan Coopersmith authored
    
    
    Resolves warnings from Oracle Parfait static analyser:
    
    Error: Misleading macro
       Misleading macro [misleading-macro]:
          misleading evaluation of ternary '?:' operator in expansion of macro V_ADDR_RB due to missing parentheses
            at line 392 of hw/xfree86/int10/generic.c.
            '|' operator has higher precedence than ternary '?:' operator inside macro body at line 431
            low precedence ternary '?:' operator is hidden by expansion of macro V_ADDR_RB at line 431
       Misleading macro [misleading-macro]:
          misleading evaluation of ternary '?:' operator in expansion of macro V_ADDR_RB due to missing parentheses
            at line 392 of hw/xfree86/int10/generic.c.
            '<<' operator has higher precedence than ternary '?:' operator inside macro body at line 431
            low precedence ternary '?:' operator is hidden by expansion of macro V_ADDR_RB at line 431
       Misleading macro [misleading-macro]:
          misleading evaluation of ternary '?:' operator in expansion of macro V_ADDR_RB due to missing parentheses
            at line 392 of hw/xfree86/int10/generic.c.
            '<<' operator has higher precedence than ternary '?:' operator inside macro body at line 442
            low precedence ternary '?:' operator is hidden by expansion of macro V_ADDR_RB at line 442
       Misleading macro [misleading-macro]:
          misleading evaluation of ternary '?:' operator in expansion of macro V_ADDR_RB due to missing parentheses
            at line 392 of hw/xfree86/int10/generic.c.
            '<<' operator has higher precedence than ternary '?:' operator inside macro body at line 443
            low precedence ternary '?:' operator is hidden by expansion of macro V_ADDR_RB at line 443
       Misleading macro [misleading-macro]:
          misleading evaluation of ternary '?:' operator in expansion of macro V_ADDR_RB due to missing parentheses
            at line 392 of hw/xfree86/int10/generic.c.
            '|' operator has higher precedence than ternary '?:' operator inside macro body at line 443
            low precedence ternary '?:' operator is hidden by expansion of macro V_ADDR_RB at line 441
       Misleading macro [misleading-macro]:
          misleading evaluation of ternary '?:' operator in expansion of macro V_ADDR_RB due to missing parentheses
            at line 392 of hw/xfree86/int10/generic.c.
            '<<' operator has higher precedence than ternary '?:' operator inside macro body at line 443
            low precedence ternary '?:' operator is hidden by expansion of macro V_ADDR_RB at line 443
    
    Signed-off-by: default avatarAlan Coopersmith <alan.coopersmith@oracle.com>
    e5386011