Skip to content
  • Adam Jackson's avatar
    dix: make RegionInit legal C++ · bb23fbf5
    Adam Jackson authored and Keith Packard's avatar Keith Packard committed
    The CVE fix in:
    
        commit 97015a07
    
    
        Author: Alan Coopersmith <alan.coopersmith@oracle.com>
        Date:   Wed Jan 22 22:37:15 2014 -0800
    
            dix: integer overflow in RegionSizeof() [CVE-2014-8092 3/4]
    
    offended the C++ demons:
    
    ../../include/regionstr.h:147:45: error: invalid conversion from 'void*' to
    'pixman_region16_data_t* {aka pixman_region16_data*}' [-fpermissive]
    
    Normally this isn't a problem, because around here we have the sense and
    common decency to not use C++, but this does make tigervnc fail to build,
    which is a little rude of us.
    
    Signed-off-by: default avatarAdam Jackson <ajax@redhat.com>
    Reviewed-by: default avatarAlan Coopersmith <alan.coopersmith@oracle.com>
    Signed-off-by: default avatarKeith Packard <keithp@keithp.com>
    bb23fbf5