Skip to content
  • Peter Hutterer's avatar
    Revert "XKB: Sanitise * actions" commits (#19602) · 3711d68f
    Peter Hutterer authored
    Reverts the following four patches:
    
    feb757f3 "XKB: Sanitise vmods for redirected keys"
    b5f49382 "XKB: Sanitise ctrls action"
    1bd7fd19 "XKB: Sanitise pointer actions"
    61c508fa "XKB: Sanitise vmods in actions"
    
    Strictly speaking, the structs used in the server are not part of the client
    ABI. Practically, they are as we copy from the wire straight into the
    structs. Changing the struct sizes breaks various wire/server conversions.
    
    Even when the structs have the same size, some internal magic causes
    conversions to fail. Visible by diffing the output files of:
    setxkbmap -layout de; xkbcomp -xkb :0 busted.xkb
    setxkbmap -layout de -print | xkbcomp -xkb - correct.xkb
    
    Interestingly enough, busted.xkb is the working one although the output is
    incorrect. Revert the four offending patches until the exact cause of this
    breakage can be determined.
    
    This patch restores functionality to Level3 modifiers.
    
    X.Org Bug 19602 <http://bugs.freedesktop.org/show_bug.cgi?id=19602
    
    >
    
    Signed-off-by: default avatarPeter Hutterer <peter.hutterer@who-t.net>
    3711d68f