From c2ffd57727e5f02b94f1c46392a740e404d4c270 Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Sun, 10 Apr 2022 09:18:41 -0700 Subject: [PATCH 1/2] Close fd for reading old Makefile when done, instead of leaking it Found by Oracle Parfait: Error: File Leak File Leak [file-ptr-leak]: Leaked File fdin at line 799 of main.c in function 'redirect'. fdin initialized at line 769 with fopen Signed-off-by: Alan Coopersmith --- main.c | 1 + 1 file changed, 1 insertion(+) diff --git a/main.c b/main.c index 8715881..816243f 100644 --- a/main.c +++ b/main.c @@ -790,6 +790,7 @@ redirect(const char *line, const char *makefile) fputs(buf, fdout); } } + fclose(fdin); fflush(fdout); #ifndef HAVE_FCHMOD chmod(makefile, st.st_mode); -- GitLab From 54559e73e27e532535dea2a60e615f99c694343f Mon Sep 17 00:00:00 2001 From: Alan Coopersmith Date: Sun, 10 Apr 2022 09:32:55 -0700 Subject: [PATCH 2/2] gitlab CI: stop requiring Signed-off-by in commits Signed-off-by: Alan Coopersmith --- .gitlab-ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.gitlab-ci.yml b/.gitlab-ci.yml index 88b5add..519431f 100644 --- a/.gitlab-ci.yml +++ b/.gitlab-ci.yml @@ -42,7 +42,7 @@ check-commits: - .fdo.ci-fairy stage: prep script: - - ci-fairy check-commits --signed-off-by --junit-xml=results.xml + - ci-fairy check-commits --junit-xml=results.xml except: - master@xorg/util/makedepend variables: -- GitLab