xf86vmproto.h xXF86VidModeModeInfo incorrect padding
Submitted by Kevin Ryde
Assigned to Jamey Sharp
(Is component "Other" right for extension protocol stuff, or is it "Protocol/Core"?)
Nosing around xf86vmproto.h I saw the xXF86VidModeModeInfo struct has its hskew field as
CARD32 hskew B16;
Is it supposed to be B32? The B macros are empty except on Cray are they? Perhaps it doesn't make a difference, or perhaps it lets the compiler bit field packing leak out ... I couldn't tell.
I wondered too if the "pad1" field there is supposed to be 32-bits. gcc reports unexpressed alignment padding after "pad1" before "flags".
gcc -Wpadded -x c -fsyntax-only /usr/include/X11/extensions/xf86vmproto.h => /usr/include/X11/extensions/xf86vmproto.h:169:12: warning: padding struct to align 'flags' [-Wpadded]
Was hskew going to be 16 then became 32 and pad1 not updated, or something?