some proto headers should be moved to server / libs

Submitted by George -

Assigned to Xorg Project Team

Link to original bug (#4712)

Description

according to symlink.sh, there are some header files that should be moved from proto modules to the server module or their respective libs. these files are marked with "not used in server" or "only used in server".

this is a reminder in case this is desirable for the modular release.

Version: git

Daniel Stone @daniels said:

Sorry about the phenomenal bug spam, guys. Adding xorg-team@ to the QA contact so bugs don't get lost in future.

Alan Coopersmith @alanc said:

Peter's finally fixed many of these now, for X11R7.5. These are now taken care of (from the list in symlink.sh):

xineramaproto

action      Xinerama.h      # not used in server

saverproto

action      scrnsaver.h     # not used in server

xextproto

action      lbxbuf.h        # not used in server
action      lbxbufstr.h     # not used in server
action      Xagsrv.h        # only used in server
action      Xdbe.h          # not used in server

These are still left in the proto modules, though they're not really protocol, nor otherwise shared between client & server:

Core protocol

action      Xthreads.h      # not used in server

fontsproto

action      FS.h            # not used in server
action      FSproto.h       # not used in server

(I believe are used indirectly in the server, via libFS/libXfont.)

trapproto

action      xtrapddmi.h     # only used in server
action      xtrapemacros.h  # not used in server
action      xtraplib.h      # not used in server
action      xtraplibp.h     # not used in server
action      xtrapproto.h    # only used in server

videoproto

action      vldXvMC.h       # not used in server

These comments in symlink.sh are just wrong and should be ignored:

Core protocol

action      ap_keysym.h     # not used anywhere
action      HPkeysym.h      # not used anywhere
action      XF86keysym.h    # only used in server

Peter Hutterer @whot said:

(In reply to comment 2)

These are still left in the proto modules, though they're not really protocol, nor otherwise shared between client & server:

Core protocol

action      Xthreads.h      # not used in server

core protocol is generally iffy, who knows who is using what. kbproto has a couple of headers that should be (re)moved too and I didn't dare touch them.

fontsproto

action      FS.h            # not used in server
action      FSproto.h       # not used in server

(I believe are used indirectly in the server, via libFS/libXfont.)

didn't dare to touch those, to tangled up.

trapproto

action      xtrapddmi.h     # only used in server
action      xtrapemacros.h  # not used in server
action      xtraplib.h      # not used in server
action      xtraplibp.h     # not used in server
action      xtrapproto.h    # only used in server

util/modular:8af23a929a40701f04ff15eaa48fa0002fbdf7bb removed trapproto from xorg.modules. Is this module unmaintained now or do we keep fixing?

videoproto

action      vldXvMC.h       # not used in server

I tried untangling this one but it's used by the drivers. I gave up after a while.

These comments in symlink.sh are just wrong and should be ignored:

Core protocol

action      ap_keysym.h     # not used anywhere
action      HPkeysym.h      # not used anywhere
action      XF86keysym.h    # only used in server

if the comments are wrong wouldn't it be best to just fix them and push it?

Jeremy Huddleston Sequoia said:

Didn't we do massive cleanup of this about 1-2 years ago? Is this bug still relevant? If so, can it be updated with current information?

removed 5. Build/Modular bugzilla labels

This still wants finishing. At least the following headers mention the Display type or include headers installed by libX11, meaning they describe libX11 interfaces and should be refactored or moved:

include/X11/extensions/Print.h
include/X11/extensions/Printstr.h
include/X11/extensions/XKBgeom.h
include/X11/extensions/fontcache.h
include/X11/extensions/vldXvMC.h
include/X11/extensions/windowswm.h
include/X11/extensions/xf86misc.h
include/X11/extensions/xf86rush.h
include/X11/extensions/xtraplib.h
include/X11/extensions/xtraplibp.h

Fortunately most of these are from obsolete extensions, so it's unlikely we'd break much.

changed milestone to %xorgproto-2019.2

mentioned in commit ajax/xorgproto@0c85a156

mentioned in merge request !9 (merged)

mentioned in commit ajax/xorgproto@1547c1cc

closed via commit 1547c1cc