libxkbfile issueshttps://gitlab.freedesktop.org/xorg/lib/libxkbfile/-/issues2019-03-30T01:49:43Zhttps://gitlab.freedesktop.org/xorg/lib/libxkbfile/-/issues/3xkbmisc.c: 2 * bad if test ?2019-03-30T01:49:43ZBugzilla Migration Userxkbmisc.c: 2 * bad if test ?## Submitted by dcb..@..il.com
Assigned to **Xorg Project Team**
**[Link to original bug (#71617)](https://bugs.freedesktop.org/show_bug.cgi?id=71617)**
## Description
I just compiled libxkbfile with extra Linux gcc flag -Wlogical...## Submitted by dcb..@..il.com
Assigned to **Xorg Project Team**
**[Link to original bug (#71617)](https://bugs.freedesktop.org/show_bug.cgi?id=71617)**
## Description
I just compiled libxkbfile with extra Linux gcc flag -Wlogical-op
It said
1.
xkbmisc.c:118:3: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]
Source code is
((ks>=XK_Ygrave)&&(ks<=XK_Fabovedot))||
but
```
[dcb@zippy4 SPECS]$ fgrep XK_Ygrave `find /usr/include/X11 -name \*.h -print`
/usr/include/X11/keysymdef.h:#define XK_Ygrave 0x1001ef2 /* U+1EF2 LATIN CAPITAL LETTER Y WITH GRAVE */
[dcb@zippy4 SPECS]$ fgrep XK_Fabovedot `find /usr/include/X11 -name \*.h -print`
/usr/include/X11/keysymdef.h:#define XK_Fabovedot 0x1001e1e /* U+1E1E LATIN CAPITAL LETTER F WITH DOT ABOVE */
[dcb@zippy4 SPECS]$
```
Suggest code rework.
2.
xkbmisc.c:132:3: warning: logical 'and' of mutually exclusive tests is always false [-Wlogical-op]
Source code is
((ks>=XK_wdiaeresis)&&(ks<=XK_ycircumflex))) {
but
```
[dcb@zippy4 SPECS]$ fgrep XK_wdiaeresis `find /usr/include/X11 -name \*.h -print`
/usr/include/X11/keysymdef.h:#define XK_wdiaeresis 0x1001e85 /* U+1E85 LATIN SMALL LETTER W WITH DIAERESIS */
[dcb@zippy4 SPECS]$ fgrep XK_ycircumflex `find /usr/include/X11 -name \*.h -print`
/usr/include/X11/keysymdef.h:#define XK_ycircumflex 0x1000177 /* U+0177 LATIN SMALL LETTER Y WITH CIRCUMFLEX */
[dcb@zippy4 SPECS]$
```
Also suggest code rework.
You may wish to consider adding gcc compiler flag -Wlogical-op
to your development builds of libxkbmisc. I checked the current
source code and these two bugs seem to still exist.https://gitlab.freedesktop.org/xorg/lib/libxkbfile/-/issues/2libxkbfile1: does not change key autorepeat state2020-10-19T11:43:51ZBugzilla Migration Userlibxkbfile1: does not change key autorepeat state## Submitted by David MartÃnez Moreno
Assigned to **Xorg Project Team**
**[Link to original bug (#9796)](https://bugs.freedesktop.org/show_bug.cgi?id=9796)**
## Description
I am acting as an intermediate for Christophe. He has fil...## Submitted by David MartÃnez Moreno
Assigned to **Xorg Project Team**
**[Link to original bug (#9796)](https://bugs.freedesktop.org/show_bug.cgi?id=9796)**
## Description
I am acting as an intermediate for Christophe. He has filed a bug in the Debian BTS, that follows:
When doing something like
xkbcomp $DISPLAY /tmp/xkb
<edit /tmp/xkb to change key autorepeat state>
xkbcomp /tmp/xkb $DISPLAY
to change some keys' autorepeat state as viewed by the X server, the
autorepeat states are silently unchanged.
I believe that this is because the code which would be responsible for
changing the state is commented out:
#ifdef NOTYET
...
#endif
in XkbWriteToServer in srvmisc.c.
My IBM X40 Thinkpad has two keys which I would like to turn into Hyper
and Super modifiers; however, their default state is to autorepeat, and
I can't turn this off using xkbcomp. (Using xset -r `<keycode>` works,
however, as does generating an XkbSetControls request manually).
I'd be happy to provide more information or provide sample files if that
would help.
Version: 7.1 (2006.05)