Signed-off-by: Matt Turner <mattst88@gmail.com>

Signed-off-by: Matt Turner <mattst88@gmail.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Ran Benita authored Aug 29, 2012 and Alan Coopersmith committed Aug 20, 2022

There are two ways to separate multiple files in XKB include statements:
'+' will cause the later file to override the first in case of conflict,
while '|' will cause it augment it (this is done by xkbcomp). '!' is
unrelated here.
Currently, if someone tries to use '|' in a rule instead of '+', it
won't have any effect. Since '|' is practically never used, this wasn't
noticed.

Signed-off-by: Ran Benita <ran234@gmail.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Found by using:
    codespell --builtin clear,rare,usage,informal,code,names

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

This fixes issue #9.

Bug existed since commit 816a8db3

 from sixteen years ago.

Signed-off-by: Benno Schulenberg <bensberg@telfort.nl>

This has been ifdef'd out since at least 2003, time to accept that it won't be
handled. One part was unreachable code anyway, the second part affects
GeomDoodads which are unnecessary and barely used anyway.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

This is the equivalent patch to xserver commit
eaf1f72ed8994b708d94ec2de7b1a99f5c4a39b8:

 XkbStringText escapes non-printable characters using octal numbers. Such escape
 sequence would be at most 5 characters long ("\0123"), so it reserves 5 bytes
 in the buffer. Due to char->unsigned int conversion, it would print much longer
 string for negative numbers.

Fixes #8



Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Reported in #5



Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Martin Burggraf authored Aug 13, 2015 and Alan Coopersmith committed Mar 24, 2018

V2: Fixing the issue with numbers between 0 -1

Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Mihail Konev authored Jan 26, 2017 and Peter Hutterer committed Jan 26, 2017

Signed-off-by: Mihail Konev <k.mvc@ya.ru>

Emil Velikov authored Mar 09, 2015 and Peter Hutterer committed Jan 26, 2017

Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Syncs the invocation of configure with the one from the server.

Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>

Andreas Wettstein authored Feb 15, 2014 and Alan Coopersmith committed Jan 01, 2016

A pointer rather than the buffer was given to sizeof.  As the data to be
written is only one or two bytes, a pointer size is at least four bytes, and
the buffer has 32 bytes, this error did not have negative effects.

Signed-off-by: Andreas Wettstein <wettstein509@solnet.ch>
Reviewed-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Andreas Wettstein authored Feb 15, 2014 and Alan Coopersmith committed Jan 01, 2016

ActionMessage has an optional flag genKeyEvent.  This change makes sure this
flag is printed when it is set.

Signed-off-by: Andreas Wettstein <wettstein509@solnet.ch>
Reviewed-By: Ran Benita <ran234@gmail.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Andreas Wettstein authored Feb 15, 2014 and Alan Coopersmith committed Jan 01, 2016

The LockMods, ISOLock and LockControls support an "affect" flag to selectively
enable and disable locking and unlocking for these actions.  This change adds
output of these flags.

Signed-off-by: Andreas Wettstein <wettstein509@solnet.ch>
Reviewed-By: Ran Benita <ran234@gmail.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Jörg Sonnenberger authored Nov 26, 2014 and Peter Hutterer committed Nov 27, 2014

The vmods member of XkbNamesPtr is an array and thus never NULL.

Signed-off-by: Thomas Klausner <wiz@NetBSD.org>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>

Other references to SEEK_SET in this file are made without checking,
since they assume everyone has either reached C89 by now or will use
the fallback #define at the top of the file, so we can stop checking
here as well.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Matches XInternAtom, which it wraps, and quiets a bunch of const warnings
in xkbcomp.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Ran Benita <ran234@gmail.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Ran Benita <ran234@gmail.com>

Some compilers can perform mind-twistingly evil optimizations
if you check for NULL after using it, others just let you segv.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Ran Benita <ran234@gmail.com>

Xserver has its own copy of this code now, so we don't need to keep
an unused copy in libxkbfile too.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Ran Benita <ran234@gmail.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Excerpt https://lists.gnu.org/archive/html/automake/2012-12/msg00038.html



  - Support for the long-deprecated INCLUDES variable will be removed
    altogether in Automake 1.14.  The AM_CPPFLAGS variable should be
    used instead.

This variable was deprecated in Automake releases prior to 1.10, which is
the current minimum level required to build X.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Colin Walters authored Jan 04, 2012 and Adam Jackson committed Jan 15, 2013

http://people.gnome.org/~walters/docs/build-api.txt



Signed-off-by: Adam Jackson <ajax@redhat.com>

Signed-off-by: Adam Jackson <ajax@redhat.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Does not fix all of them, as some affect the API and thus need more analysis.

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>

Our minimum requirement for X11 is currently Unix98.  Unix98 provides
strcasecmp in <strings.h>.  This commit fixes implicit declarations
of this function on systems that closely adhere to the standard.

Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>

Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Group statements per section as per Autoconf standard layout
Quote statements where appropriate.
Autoconf recommends not using dnl instead of # for comments

Use AC_CONFIG_FILES to replace the deprecated AC_OUTPUT with parameters.
Add AC_CONFIG_SRCDIR([Makefile.am])
Remove redundant AC_SUBST(*_CFLAGS) and/or *_LIBS
Update minimum version of util-macros to at least 1.8.
No functional configuration changes

This helps automated maintenance and release activities.
Details can be found in http://wiki.x.org/wiki/NewModuleGuidelines