Skip to content
GitLab
  • Menu
Projects Groups Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in / Register
  • L libxcvt
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Repository
    • Repository
    • Files
    • Commits
    • Branches
    • Tags
    • Contributors
    • Graph
    • Compare
  • Issues 2
    • Issues 2
    • List
    • Boards
    • Service Desk
    • Milestones
  • Merge requests 2
    • Merge requests 2
  • CI/CD
    • CI/CD
    • Pipelines
    • Jobs
    • Schedules
  • Deployments
    • Deployments
    • Environments
    • Releases
  • Packages & Registries
    • Packages & Registries
    • Package Registry
    • Container Registry
    • Infrastructure Registry
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
    • CI/CD
    • Repository
  • Wiki
    • Wiki
  • Snippets
    • Snippets
  • Activity
  • Graph
  • Create a new issue
  • Jobs
  • Commits
  • Issue Boards
Collapse sidebar
  • xorg
  • lib
  • libxcvt
  • Merge requests
  • !9

Make xrandr report 1366x768 instead of 1360x768

  • Review changes

  • Download
  • Email patches
  • Plain diff
Merged Dima Krasner requested to merge dimkr/libxcvt:master into master Apr 04, 2022
  • Overview 11
  • Commits 1
  • Pipelines 2
  • Changes 1

I think Xwayland 22.1 introduced a regression caused by the libxcvt transition.

I have a very particular use case that exposes this regression: a fullscreen ("rootful") Xwayland window running a traditional X window manager (specifically, JWM), under a wlroots-based compositor. The problem can be reproduced with either Cage or dwl, and wlroots 0.15.1.

There's a 6px gap on the right of the panel drawn by the window manager, although it is possible to place X windows over this gap:

2

This probably means that the Xwayland window is 1366x768, but the X applications inside it think it's 1360x768.

Unsurprisingly, xrandr says the display mode is 1360x768, although wlr-randr reports the correct resolution of 1366x768.

If this is indeed a regression, it's a re-introduction of https://bugs.freedesktop.org/show_bug.cgi?id=99574. Maybe libxcvt isn't the right place for this magic if, which was originally in xwayland-cvt.c.

Edited Apr 04, 2022 by Dima Krasner
Assignee
Assign to
Reviewer
Request review from
Time tracking
Source branch: master