Signed-off-by: Jamey Sharp <jamey@minilop.net>

Pauli Nieminen authored Jun 11, 2010 and Peter Harris committed Jun 15, 2010

protocol and host are allocated in _xcb_parse_display but ownership of
them is passed to the caller. They have to be freed in
xcb_connect_to_display_with_auth_info.
Signed-off-by: Pauli Nieminen <ext-pauli.nieminen@nokia.com>
Signed-off-by: Peter Harris <pharris@opentext.com>

Pauli Nieminen authored Jun 11, 2010 and Peter Harris committed Jun 15, 2010

xcb_parse_display claims that there is no side effects when failing.
That requires _xcb_parse_display to free the memory in failure case.
Signed-off-by: Pauli Nieminen <ext-pauli.nieminen@nokia.com>
Signed-off-by: Peter Harris <pharris@opentext.com>

Support scenarios where host is not set and protocol is.  eg:

DISPLAY=tcp/:0

as well as the "inet" and "inet6" alias for "tcp" for compatability
with Xlib
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>
Reviewed-by: Jamey Sharp <jamey@minilop.net>

Marcin Kościelnicki authored May 13, 2010 and Julien Danjou committed May 14, 2010

Reviewed-by: Julien Cristau <jcristau@debian.org>
Signed-off-by: Julien Danjou <julien@danjou.info>

This is a regression found by tinderbox in previous commit:

xcb_util.c: In function '_xcb_open':
xcb_util.c:213: error: 'fd' undeclared (first use in this function)

There could be no upper limit on the length of a path according
to POSIX, therefore these macros may not be defined at all on
some systems (such as GNU Hurd).
Signed-off-by: Arnaud Fontaine <arnau@debian.org>
Reviewed-by: Peter Harris <pharris@opentext.com>

Regression found by tinderbox in 89b3485d



xcb_util.c:31:27: error: sys/syslimits.h: No such file or directory
xcb_util.c: In function '_xcb_open':
xcb_util.c:148: error: 'PATH_MAX' undeclared (first use in this function)
Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>

Fixes: http://xquartz.macosforge.org/trac/ticket/390

Signed-off-by: Jeremy Huddleston <jeremyhu@apple.com>

Since writers must make sure they read as well, threads may have gone to
sleep waiting for the opportunity to read. The writer must wake up one
of those readers or the application can hang.
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Reviewed-by: Josh Triplett <josh@freedesktop.org>

xcb_ge_event_t has its length field in the same place that
xcb_generic_reply_t does, so there's no need to cast the generic reply.
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Cc: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Julien Danjou <julien@danjou.info>

_xcb_out_send needs _xcb_conn_wait to store back its progress so it can
be reinvoked to pick up where it left off---but then _xcb_out_send
guarantees that it leaves either an empty output vector or a shut-down
connection, so *its* callers never care how much progress was made.
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Reviewed-by: Josh Triplett <josh@freedesktop.org>

Rémi Denis-Courmont authored Mar 26, 2010 and Julien Danjou committed Apr 08, 2010

Depending on the process file limit, a file descriptor can be larger
than the capacity of fd_set. There is no portable way to create a
large enough fd_set at run-time. So we just fail if the file descriptor
number is too high and poll() is not available.
Reviewed-by: Jamey Sharp <jamey@minilop.net>
Signed-off-by: Julien Danjou <julien@danjou.info>

Samuel Thibault authored Mar 12, 2010 and Julien Danjou committed Mar 13, 2010

libxcb's 010e5661

 (Fix XDM-AUTHORIZATION-1 (bug #14202)) mistakenly
inverted a few lines of code, making local socket authentication fail on
hpux and Hurd: when getpeername fails, sockname needs to be initialized
by getsockname before its address family can be checked.
Signed-off-by: Samuel Thibault <samuel.thibault@ens-lyon.org>
Signed-off-by: Julien Danjou <julien@danjou.info>

Remi Denis-Courmont authored Feb 13, 2010 and Julien Danjou committed Feb 17, 2010

This saves the X11 connection from leaking into children processes.
On Linux, this is fully thread-safe using SOCK_CLOEXEC. On other
systems, there is a small race condition.
Signed-off-by: Julien Danjou <julien@danjou.info>

This function is useful for dynamic language garbage collectors. Frequently
a GC cycle may run before you want to block wainting for a reply.

This function is also marginally useful for libxcb apps that issue
speculative requests (eg. xlsclients).
Reviewed-by: Jamey Sharp <jamey@minilop.net>
Tested-by: Eamon Walsh <efw@eamonwalsh.com>
Signed-off-by: Peter Harris <pharris@opentext.com>

Remi Denis-Courmont authored Jan 07, 2010 and Julien Danjou committed Jan 07, 2010

Signed-off-by: Julien Danjou <julien@danjou.info>

Signed-off-by: Julien Danjou <julien@danjou.info>

This matches xtrans behaviour in SocketINETConnect, and makes it so apps
don't hang forever if their display dies.
Signed-off-by: Adam Jackson <ajax@redhat.com>

v2: Build fix from jcristau.

Yaakov Selkowitz authored Jun 06, 2009 and Julien Danjou committed Aug 31, 2009

-no-undefined is needed to tell libtool a shared library can be built
on platforms which require all references to be statisfied at link time.
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Signed-off-by: Julien Danjou <julien@danjou.info>

Also replace excessively clever use of bitwise OR with equivalent
addition.
Reported-by: Geoffrey Li <geoffrey@seitopos.com>
Signed-off-by: Jamey Sharp <jamey@minilop.net>
Signed-off-by: Josh Triplett <josh@joshtriplett.org>

Julien Cristau authored May 29, 2009 and Julien Danjou committed May 29, 2009

The SONAME shouldn't have been bumped in 1.3, only new symbols were
added.
Signed-off-by: Julien Danjou <julien@danjou.info>

elupus authored May 26, 2009 and Julien Danjou committed May 26, 2009

Signed-off-by: Julien Danjou <julien@danjou.info>

Signed-off-by: Julien Danjou <julien@danjou.info>

Bart Massey authored Apr 21, 2009 and Julien Danjou committed Apr 21, 2009

With this patch, we know use correctly the socket address or peer
address for authentication purpose.
Signed-off-by: Julien Danjou <julien@danjou.info>

Signed-off-by: Julien Danjou <julien@danjou.info>

Many code was duplicated between xcb_connect_to_display_with_auth_info
and xcb_connect(). We merge both, since the difference is just about the
xcb_auth_info_t pointer being supplied, or not.
Signed-off-by: Julien Danjou <julien@danjou.info>

That saves us from a couple of strlen() calls.
Signed-off-by: Julien Danjou <julien@danjou.info>

That save us from a strlen().
Signed-off-by: Julien Danjou <julien@danjou.info>

Signed-off-by: Julien Danjou <julien@danjou.info>

Samuel Thibault authored Apr 06, 2009 and Julien Danjou committed Apr 06, 2009

Local socket connections currently do not work on hurd-i386 because
xcb_auth calls getpeername() on the client socket, but hurd-i386 does
not implement anything in that case (I actually wonder what reasonable
value could be returned).  In such case the xcb code does not actually
need the peer name anyway.
Signed-off-by: Julien Danjou <julien@danjou.info>

Michael Ost authored Mar 30, 2009 and Julien Danjou committed Mar 30, 2009

Signed-off-by: Julien Danjou <julien@danjou.info>

Bart Massey authored Mar 24, 2009 and Julien Danjou committed Mar 28, 2009

Signed-off-by: Bart Massey <bart@cs.pdx.edu>
Signed-off-by: Julien Danjou <julien@danjou.info>

Signed-off-by: Julien Danjou <julien@danjou.info>

Signed-off-by: Julien Danjou <julien@danjou.info>

These changes are necessary to build with latest xcb/proto.
Signed-off-by: Peter Harris <pharris@opentext.com>

This commit broke xcb/util.

This reverts commit 9984b728

.
Signed-off-by: Peter Harris <pharris@opentext.com>

Signed-off-by: Peter Harris <pharris@opentext.com>