When an xcb_connection_t goes into an error state, all operations on it will
fail. This means that after a call to xcb_key_symbols_get_reply(), syms->u.reply
would still be a NULL pointer and that xcb_get_setup() returns a NULL pointer.

The only way for xcb_get_setup() to return NULL is for an error connection, but
xcb_get_keyboard_mapping_reply() could also fail for other reasons. So to fix
this, all functions need to check for error connections and if syms->u.reply is
not NULL.

This was tested with the following C code:

  #include <xcb_keysyms.h>
  #include <stdio.h>
  #include <stdlib.h>

  int main()
  {
  	xcb_connection_t *c = xcb_connect(NULL, NULL);
  	xcb_key_symbols_t *syms = xcb_key_symbols_alloc(c);
  	/* The above sent a GetKeyboardMapping request. Let's now break the
  	 * connection so that it cannot get the reply.
  	 */
  	uint32_t max = xcb_get_maximum_request_length(c);
  	xcb_screen_t *s = xcb_setup_roots_iterator(xcb_get_setup(c)).data;
  	size_t l...

Bastien Dejean authored Jan 02, 2013 and Michael Stapelberg committed Feb 24, 2013

When multiple keysym matches occur on one keycode, we do not want to
return that keycode multiple times.

Signed-off-by: Bastien Dejean <nihilhill@gmail.com>
Signed-off-by: Michael Stapelberg <michael+xcb@stapelberg.de>

Andreas Wettstein authored Aug 07, 2011 and Julien Danjou committed Jan 11, 2012

xcb_is_modifier_key did not regecognise ISO_Level5_Shift,
ISO_Level5_Latch, and ISO_Level5_Lock as modifiers.  See bug
39177, https://bugs.freedesktop.org/show_bug.cgi?id=39177



Signed-off-by: Andreas Wettstein <wettstein509@solnet.ch>
Reviewed-by: James Cloos <cloos@jhcloos.com>
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
Signed-off-by: Julien Danjou <julien@danjou.info>

Signed-off-by: Julien Danjou <julien@danjou.info>

xcb_key_symbols_get_keycode() returned a keycode.
That's wrong, since actually a keysym can have multiple keycode. And we
usually need all this keycodes to correctly grab a keysym.

Signed-off-by: Julien Danjou <julien@danjou.info>

This reverts commit 24da2934.

Signed-off-by: Julien Danjou <julien@danjou.info>

Signed-off-by: Julien Danjou <julien@danjou.info>

Signed-off-by: Bart Massey <bart@cs.pdx.edu>

Many of the exported library functions still need to follow the new convention.

by moving many defs from X.h to <enum>s in xproto.xml