Mihail Konev authored Jan 26, 2017 and Alan Coopersmith committed Jul 24, 2022

Signed-off-by: Mihail Konev <k.mvc@ya.ru>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Emil Velikov authored Mar 09, 2015 and Alan Coopersmith committed Jul 24, 2022

Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent
fall-outs, when they contain space.
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Reviewed-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Peter Hutterer authored Jan 24, 2017 and Alan Coopersmith committed Jul 24, 2022

Syncs the invocation of configure with the one from the server.
Signed-off-by: Peter Hutterer <peter.hutterer@who-t.net>
Reviewed-by: Emil Velikov <emil.velikov@collabora.com>
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

See http://people.gnome.org/~walters/docs/build-api.txt

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>

There is only one target in this directory, so we do not need to trigger
the per-target infrastructure which would require AC_PROG_CC_C_O macro.
So libxcb_image_la-xcb_image.o simply becomes xcb_image.o.

http://www.gnu.org/software/automake/manual/automake.html#Renamed-Objects

Reviewed-by: Uli Schlachter <psychon@znc.in>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Seperate building the production code from the test programs, out of
principal and as it opens the possibilities of simplification in
follow-up patches. Avoid file names like test_xcb_image_shm-test_xcb_image_shm
Reviewed-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

This package may theorically be installed at a different location.
Reviewed-by: Uli Schlachter <psychon@znc.in>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

All files mentionned in AC_CONFIG_FILES have their source files
distributed automatically.

http://www.gnu.org/software/automake/manual/automake.html

Reviewed-by: Uli Schlachter <psychon@znc.in>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Files generated by autoconf (and the various tools it calls) must not be
removed by running a makefile. This is outside the scope of the makefile.

http://lists.gnu.org/archive/html/autoconf/2007-03/msg00043.html



One can use git-clean to return to the original state of the module prior
to running autogen.sh, autoreconf or configure.
Reviewed-by: Uli Schlachter <psychon@znc.in>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

This file is mandatory. It reflects the copyright statements found
in the source code as written by their respective owners.
Reviewed-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

This file contains C preprocessor #define statements which replace
the current -Ds added to each compilation invocation.

This makes the gcc output command easier to read and prevents exceeding
the max line limits on some computers. This is the preferred method
in al the xorg modules.
Reviewed-by: Uli Schlachter <psychon@znc.in>
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Reviewed-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Fix Automake warning: AC_OUTPUT should be used without arguments.
www.gnu.org/software/autoconf/manual/autoconf.html#Configuration-Files

Changed layout to one file per file like other xorg modules.
Reviewed-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Use same layout as libxcb.
Reviewed-by: Josh Triplett <josh@joshtriplett.org>
Reviewed-by: Uli Schlachter <psychon@znc.in>
Signed-off-by: Gaetan Nadon <memsize@videotron.ca>

Exit early with an informative message if the submodules are missing,
since they are needed.  Without this autoconf throws a bunch of
uninformative errors which does not point to the actual problem.
This was taken from util-keysyms.
Signed-off-by: Niclas Zeising <zeising@daemonic.se>
Reviewed-By: Arnaud Fontaine <arnau@debian.org>

The endianness of the returned bit planes does not depend on
the host bit order in the current server, and apparently not
in the spec. So..yeah.

Or at least made it work a little. There may still be many bugs
here depending on endianness, size vs stride, etc.

Jon Turney authored Dec 20, 2012 and Peter Harris committed Feb 06, 2013

XORG_DEFAULT_OPTIONS enables -Werror=return-type

xcb_image_get_pixel() and xcb_image_create_native() assume assert(0) is
noreturn, and don't return a value in that case.  But assert(0) isn't noreturn
if NDEBUG is defined.

Fix this by returning a suitable value.

(Also, on the MinGW target, assert(0) is non-standard and may return even in the
!NDEBUG case, as the C runtime may ask the user if they want to abort or not...)

/jhbuild/checkout/xcb/xcb-util-image/image/xcb_image.c: In function 'xcb_image_get_pixel':
/jhbuild/checkout/xcb/xcb-util-image/image/xcb_image.c:754:1: error: control reaches end of non-void function [-Wreturn-type]
/jhbuild/checkout/xcb/xcb-util-image/image/xcb_image.c: In function 'xcb_image_create_native':
/jhbuild/checkout/xcb/xcb-util-image/image/xcb_image.c:190:1: error: control reaches end of non-void function [-Wreturn-type]
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Signed-off-by: Peter Harris <pharris@opentext.com>

Signed-off-by: Arnaud Fontaine <arnau@debian.org>

it is more portable (for example, to MinGW)
Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Reviewed-by: Arnaud Fontaine <arnau@debian.org>

Signed-off-by: Jon TURNEY <jon.turney@dronecode.org.uk>
Reviewed-by: Arnaud Fontaine <arnau@debian.org>