1. 17 Feb, 2019 3 commits
  2. 11 Jul, 2017 1 commit
    • Uli Schlachter's avatar
      documentation: Call xcb_free_cursor() when done · 947eaba9
      Uli Schlachter authored
      The documentation for xcb_cursor_load_cursor() say that the resulting
      cursor must be freed, but the example in the documentation does not do
      so. It does not matter much for this example, but I think it is a good
      idea to use it to hint to this requirement. Also, the example already
      uses xcb_cursor_context_free(), so it tries to clean up after itself.
      Signed-off-by: Uli Schlachter's avatarUli Schlachter <psychon@znc.in>
  3. 12 May, 2016 2 commits
  4. 25 Mar, 2015 1 commit
  5. 22 Mar, 2015 1 commit
    • Martin Gräßlin's avatar
      Perform safety check before trying to load glyph cursor · cf26479e
      Martin Gräßlin authored
      The passed in cursor name to xcb_cursor_load_cursor might not match
      one of the predefined font cursor values. Without the check the
      call to create glyph cursor will fail with a BadValue error, but
      the library returns the id allocated for the xcb_cursor_t. A user
      of the library gets a value which looks like a valid cursor, but
      when using it for e.g. a cursor value in xcb_create_window it raises
      a BadCursor error.
  6. 05 Apr, 2014 1 commit
  7. 29 Jan, 2014 1 commit
  8. 24 Dec, 2013 1 commit
  9. 12 Nov, 2013 1 commit
  10. 09 Nov, 2013 1 commit
  11. 07 Nov, 2013 1 commit
  12. 13 Oct, 2013 2 commits
    • Uli Schlachter's avatar
      Fail the build if gperf is needed, but not found · 0bde33d9
      Uli Schlachter authored
      The rule that cursor/Makefile.am uses for calling gperf can be found on the
      internet[0]. That page explains three cases that should be handled:
      1. gperf succeeded
      2. gperf failed
      3. gperf is missing
      The reasoning for the third case is:
        If $(GPERF) does not answer to --version, it is certainly missing, and missing
        already suggested to install Gperf. Then remove the temporary output file, and
        let the compilation proceed by updating the timestamp of the output file.
        That's a best effort, essentially helping users who get the project with
        broken timestamps.
      However, this assumes that the user is building from a tarball which already
      contains a working version of the output C file. When building from git, this
      file does not exist and instead of updating the timestamp of the output file,
      this Makefile rule would create the output file.
      Thus, the following four cases need to be handled:
      1. gperf succeeded
      2. gperf failed
      3. gperf is missing and the output file already exists
      4. gperf is missing and the output file is missing, too
      For the third case, the above reasoning applies. However, in the fourth case,
      the build would continue and produce a broken library. For xcb-util-cursor this
      means that linking to this library would fail with "undefined reference to
      `cursor_shape_to_id'". So in this case the build should fail.
      [0]: http://www.lrde.epita.fr/~akim/ccmp/doc/gnuprog2/Using-Gperf-with-the-GNU-Build-System.htmlSigned-off-by: Uli Schlachter's avatarUli Schlachter <psychon@znc.in>
    • Uli Schlachter's avatar
      Use $(AM_V_GEN) when calling gperf · 0d84049a
      Uli Schlachter authored
      This adds support for automake's silent mode to the gperf rule. In silent mode,
      make will not print the whole command lines, but only a short version of what it
      For this rule, "GEN shape_to_id.c" will be printed.
      Signed-off-by: Uli Schlachter's avatarUli Schlachter <psychon@znc.in>
  13. 08 Oct, 2013 1 commit
  14. 20 Sep, 2013 2 commits
  15. 21 Aug, 2013 2 commits
  16. 18 Aug, 2013 1 commit
  17. 12 Aug, 2013 2 commits
  18. 13 Jul, 2013 1 commit
  19. 12 Jul, 2013 1 commit
  20. 09 Jul, 2013 9 commits
  21. 13 Jan, 2013 4 commits
  22. 12 Jan, 2013 1 commit