Suspicious XawMax in GetBlockBoundaries
In GetBlockBoundaries
, the following code looks suspicious:
XawMax(ctx->text.s.right, ctx->text.s.right)
I suspect this is a simple typo and that the left right
should be left
.
On the other hand, this code is 18 years old, so somebody else should have already stumbled upon it.
I found it when I opened the preprocessed source code in CLion, where Clang warned:
Self-comparison always evaluates to false