1. 08 Dec, 2018 1 commit
  2. 21 Aug, 2018 3 commits
    • Tobias Stoeckmann's avatar
      Fixed crash on invalid reply (CVE-2018-14598). · e8372276
      Tobias Stoeckmann authored
      If the server sends a reply in which even the first string would
      overflow the transmitted bytes, list[0] (or flist[0]) will be set to
      NULL and a count of 0 is returned.
      If the resulting list is freed with XFreeExtensionList or
      XFreeFontPath later on, the first Xfree call:
          Xfree (list[0]-1)
       turns into
          Xfree (NULL-1)
      which will most likely trigger a segmentation fault.
      I have modified the code to return NULL if the first string would
      overflow, thus protecting the freeing functions later on.
      Signed-off-by: Tobias Stoeckmann's avatarTobias Stoeckmann <tobias@stoeckmann.org>
    • Tobias Stoeckmann's avatar
      Fixed out of boundary write (CVE-2018-14600). · dbf72805
      Tobias Stoeckmann authored
      The length value is interpreted as signed char on many systems
      (depending on default signedness of char), which can lead to an out of
      boundary write up to 128 bytes in front of the allocated storage, but
      limited to NUL byte(s).
      Casting the length value to unsigned char fixes the problem and allows
      string values with up to 255 characters.
      Signed-off-by: Tobias Stoeckmann's avatarTobias Stoeckmann <tobias@stoeckmann.org>
    • Tobias Stoeckmann's avatar
      Fixed off-by-one writes (CVE-2018-14599). · b469da14
      Tobias Stoeckmann authored
      The functions XGetFontPath, XListExtensions, and XListFonts are
      vulnerable to an off-by-one override on malicious server responses.
      The server replies consist of chunks consisting of a length byte
      followed by actual string, which is not NUL-terminated.
      While parsing the response, the length byte is overridden with '\0',
      thus the memory area can be used as storage of C strings later on. To
      be able to NUL-terminate the last string, the buffer is reserved with
      an additional byte of space.
      For a boundary check, the variable chend (end of ch) was introduced,
      pointing at the end of the buffer which ch initially points to.
      Unfortunately there is a difference in handling "the end of ch".
      While chend points at the first byte that must not be written to,
      the for-loop uses chend as the last byte that can be written to.
      Therefore, an off-by-one can occur.
      I have refactored the code so chend actually points to the last byte
      that can be written to without an out of boundary access. As it is not
      possible to achieve "ch + length < chend" and "ch + length + 1 > chend"
      with the corrected chend meaning, I removed the inner if-check.
      Signed-off-by: Tobias Stoeckmann's avatarTobias Stoeckmann <tobias@stoeckmann.org>
  3. 20 Aug, 2017 1 commit
    • Walter Harms's avatar
      Fixes: warning: variable 'req' set but not,used · 2911c39c
      Walter Harms authored
      Fixes: warning: variable 'req' set but not used [-Wunused-but-set-variable]
             by marking req _X_UNUSED
      	Solution was discussed on xorg-devel ML
             Peter Hutter, Alan Coopersmith
              Re: [PATCH libX11 3/5] fix: warning: pointer targets in passing argument 2 of '_XSend' differ in signedness [-Wpointer-sign]
      Signed-off-by: harms wharms@bfs.de
  4. 19 May, 2015 1 commit
  5. 07 Jun, 2014 1 commit
  6. 20 Aug, 2013 1 commit
  7. 21 Jul, 2013 1 commit
  8. 10 May, 2013 1 commit
  9. 07 Jul, 2010 1 commit
  10. 15 Jan, 2010 1 commit
  11. 01 May, 2007 1 commit
  12. 13 May, 2005 1 commit
  13. 23 Apr, 2004 1 commit
  14. 14 Nov, 2003 1 commit