Skip to content

voodoo_find_dac doesn't check device_ids

The Oracle Parfait 4.0 static analyzer reports:

Warning: Unread variable
   Unread variable [unread-var]:
      Variable 'device_id' is never read
        at line 380 of driver/xf86-video-voodoo/src/voodoo_hardware.c in function 'voodoo_find_dac'.
Warning: Logical operation on constant
   Logical operation on constant [logical-constant-operand]:
      Use of logical '&&' with constant operand
        at line 393 of driver/xf86-video-voodoo/src/voodoo_hardware.c.
   Logical operation on constant [logical-constant-operand]:
      Use of logical '&&' with constant operand
        at line 396 of driver/xf86-video-voodoo/src/voodoo_hardware.c.

It looks like there should be device_id == after the && in lines 393 & 396, but I have no hardware to test such a change.

Edited by Alan Coopersmith
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information