blade_accel_exa.c:96: bad switch statement ?
Submitted by dcb..@..il.com
Assigned to Xorg Project Team
Description
I just ran the static analyser "cppcheck" over the source code of the Redhat Fedora package xorg-x11-drv-trident.
It said
[blade_accel_exa.c:96] -> [blade_accel_exa.c:98]: (warning) Variable 'ret' is reassigned a value before the old one has been used. 'break;' missing?
Source code is
case 15:
ret = 5UL << 29; /* 555 */
case 16:
ret = 1UL << 29; /* 565 */
break;
Suggest add break after first case.