xspice: Don't create Xorg time in timer_add
SpiceCoreInterface::timer_add() is used by spice-server for integration with external mainloops. timer_add() is only meant to create a disabled timer, this timer will then be started with a call to timer_start(). The current implementation in Xspice creates a timer which will trigger in a very long time, assuming this will never happen. This 'forever' is 1,000,000 seconds, which amounts to 11 days. After that time, some timers which are meant to be disabled (eg migration related timers in spice-server) fire, then causing a crash with some failed assertions. Instead of creating the X timer right away in timer_add(), we can wait until timer_start() is called before starting it, which avoids this issue.
Showing with 2 additions and 2 deletions