Commit cf2254c1 authored by Victor Toso's avatar Victor Toso Committed by Christophe Fergeau

qxl: Initialize prev field while dup surface list

Otherwise we will can hit a segfault qxl_surface_kill()

 │717     void
 │718     qxl_surface_kill (qxl_surface_t *surface)
 │719     {
 │720         struct evacuated_surface_t *ev = surface->evacuated;
 │721
 │722         if (ev)
 │723         {
 │724             /* server side surface is already destroyed (via reset), don't
 │725              * resend a destroy. Just mark surface as not to be recreated */
 │726             ev->pixmap = NULL;│
 │727             if (ev->image)│
 │728                 pixman_image_unref (ev->image);
 │729             if (ev->next)
 │730                 ev->next->prev = ev->prev;
 │731             if (ev->prev)
>│732                ev->prev->next = ev->next;
 │733             free(ev);
 │734             surface->evacuated = NULL;
 │735             return;
 │736         }

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1641793Signed-off-by: 's avatarVictor Toso <victortoso@redhat.com>
parent 64cb597c
...@@ -792,6 +792,7 @@ qxl_surface_cache_evacuate_all (surface_cache_t *cache) ...@@ -792,6 +792,7 @@ qxl_surface_cache_evacuate_all (surface_cache_t *cache)
unlink_surface (s); unlink_surface (s);
evacuated->prev = NULL;
evacuated->next = evacuated_surfaces; evacuated->next = evacuated_surfaces;
if (evacuated_surfaces) if (evacuated_surfaces)
evacuated_surfaces->prev = evacuated; evacuated_surfaces->prev = evacuated;
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment