- 05 Apr, 2018 2 commits
-
-
Chris Wilson authored
Having just chased a bug along this path, I found the following debug helpful in a narrowing down why certain paths were chosen. Signed-off-by:Chris Wilson <chris@chris-wilson.co.uk>
-
Chris Wilson authored
We were telling the kernel the correct location for it to fill the 64b relocation, but we were writing the presumed offset into the wrong pair of dwords in the batch ourselves. For the frequent case where we used a new upload buffer, the kernel would perform the fixup and correct our mistake, but if we happened to reuse a buffer then we told the gpu to source the stipple from the wrong address. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105886 Signed-off-by:
-
- 04 Apr, 2018 2 commits
-
-
Chris Wilson authored
When we mix TearFree and per-crtc pixmaps (e.g. for RandR transformations), we stash the old buffer on the CRTC for double buffering. However, this buffer needs to be reallocated when we change output resolutions, as the CRTC size may change. Signed-off-by: -
Chris Wilson authored
kgem_bo_map__(cpu|gtt) leaves the sync up to the caller, in particular so that the obtaining the pointer and controlling the cache domains are not conflated and can be separated. However, it does mean that the caller can not assume that obtaining the pointer updates the cache domains, as it does not. memcpy_copy_boxes fell into this trap. Signed-off-by:
-
- 03 Apr, 2018 3 commits
-
-
Chris Wilson authored
TearFree wants to grab the most recently used scanout for rendering the next frame into. If the flip event was still pending, we would then query the drm event buffer for any pending completions, but this would proceed to execute all the other events before the flip events as well. Since we they were out of sequence, we pushed them into a buffer to execute afterwards, however we forgot the side effects of the flip handlers, for example see commit af36a4ab ("sna: Defer submission of the next shadow frame until halfway through") and that there may have been events read from drm into a local buffer inside sna_mode_wakeup() that haven't been processed yet. Eliminate the need for calling sna_mode_wakeup() by ensuring that all flip events have been completed first before handing the vblank callbacks and potential drawing, ensuring the correct ordering. References: https://bugs.freedesktop.org/show_bug.cgi?id=105720 Signed-off-by:
-
Chris Wilson authored
We shouldn't even be attempting to redisplay if there are flips pending, so exit early and expect to be called again after the pending flips complete. Exiting early avoids having to call sna_mode_wakeup() in what used to be a potentially recursive manner (see commit af36a4ab "sna: Defer submission of the next shadow frame until halfway through"). Signed-off-by:
-
Chris Wilson authored
Do not try and workaround the failure by forcing the wait-for-flip as we may be inside a vblank handler already. Just report the move failed and expect the caller to skip the draw, fairly standard practice for allocation failure handling (stale output rather than crash). Signed-off-by:
-
- 01 Apr, 2018 2 commits
-
-
Chris Wilson authored
Do not immediately post the next shadow flip on completion of the current flips, but instead queue a timer for half way through the next vblank so that try to we keep the additional input-output lag to less than a frame. Signed-off-by: -
Chris Wilson authored
The update for ABI 22 and NotifyFd left behind an important flush for shadow rendering. Fixes: 4ab9145c7748 ("Update to ABI 22 and NotifyFd") Signed-off-by:
-
- 28 Mar, 2018 1 commit
-
-
Chris Wilson authored
Since forever we have been passing region=NULL when doing a windowed swapbuffer on vblank, and using that to mark the entire pixmap as being damaged. For an uncomposited window, this is incorrect as it points to a clipped region of the ScreenPixmap and so we were marking the entire ScreenPixmap as being flushed, but only having operated on the windowed region. Instead pass along the clip extents if region is unset. References: https://bugs.freedesktop.org/show_bug.cgi?id=105720 Signed-off-by:
-
- 26 Mar, 2018 1 commit
-
-
Chris Wilson authored
During early init, xf86ScrnToScreen() may return NULL, so handle that possibility inside the assert. Signed-off-by:
-
- 02 Mar, 2018 2 commits
-
-
For my HTPC setup, I'm using the option "CustomEDID". With this option, output attaching and destroying events leads to crashes. The following sequence leads to a crash: - In xorg.conf: Option "CustomEDID" "HDMI2:/etc/my_edid.bin" - Starting Xorg - Connect HDMI2 - Disconnect HDMI2 - Reconnect HDMI2 -> Crash The crash happens in xf86OutputSetEDID (xorg/xserver/hw/xfree86/modes/xf86Crtc.c) at "free(output->MonInfo)". MonInfo is assigned with sna_output->fake_edid_mon which is allocated by intel driver in sna_output_load_fake_edid (src/sna/sna_display.c). Sequence details: - Starting Xorg -> fake_edid_mon is initialized - Connect HDMI2 -> xf86OutputSetEDID is called: - MonInfo is NULL - MonInfo is assigned with fake_edid_mon pointer - MonInfo is read by Xorg - Disconnect HDMI2 - Reconnect HDMI2 -> xf86OutputSetEDID is called: - MonInfo is freed thus also fake_edid_mon - MonInfo is assigned with fake_edid_mon - MonInfo is read but it was freed -> CRASH The fix consists of a new instance of xf86MonPtr for each calls of xf86OutputSetEDID. is initialized with fake_edid_raw which render fake_edid_mon useless. With this proposal, the behaviour of an EDID override is similar to a "real" EDID. Signed-off-by:Dominique Constant <dom.constant@free.fr> Reviewed-by:
-
Use the new "COLOR_ENCODING" plane property to implement the XV_COLORSPACE port attribute for sprite Xv adaptors. v2: assert(colorspace < ARRAY_SIZE) (Chris) Cc: Jyri Sarha <jsarha@ti.com> Cc: Chris Wilson <chris@chris-wilson.co.uk> Signed-off-by:
Ville Syrjälä <ville.syrjala@linux.intel.com> Reviewed-by:
-
- 14 Feb, 2018 1 commit
-
-
Oops. We never actually select the NV12 shader on gen8, causing us to render garbage. Looks like this is the only one I somehow missed. Signed-off-by:
-
- 08 Feb, 2018 1 commit
-
-
Chris Wilson authored
Before checking st_rdev, we first need to validate that the file is a device node, but we only want to check the file type bits and not compare the permissions. Reported-by:
Ilia Mirkin <imirkin@alum.mit.edu> Signed-off-by:
-
- 07 Feb, 2018 1 commit
-
-
Chris Wilson authored
The PICT_ are enums and so never report true to ifdef PICT_a2r10g10b10 and instead we need to check the xserver version they were introduced. Reported-by:
-
- 06 Feb, 2018 4 commits
-
-
Allow building the driver with meson. Could probably use plenty of cleanups, but at least it gives me a working driver. And I think I managed to make it build everything that autotools builds. Quite a few compiler warnings were suppressed as well. Might want to look at those at some point. Signed-off-by: -
IPC_RMID_DEFERRED_RELEASE is unused so nuke it. Signed-off-by: -
Use do{}while(0) for DBG() and ERR() to avoid isses with if/else/etc. Signed-off-by: -
SKL reintroduced plane scaling once more. Let's try to make use of it. The one annoying caveat is that you can't do colorkeying and scaling at the same time :( For now we'll leave the choice of colorkey vs. scaling to the user via that XV_ALWAYS_ON_TOP attribute. One possible idea for improving the situation would be to add support for autopaint colorkey, and automatically disable the colorkey whenever the window is not obscured by anything and autopaint colorkey is enabled. Signed-off-by:
-
- 11 Jan, 2018 1 commit
-
-
Add the Coffeelake PCI IDs based on the following kernel patches: commit b056f8f3d6b900e8afd19f312719160346d263b4 Author: Anusha Srivatsa <anusha.srivatsa@intel.com> Date: Thu Jun 8 16:41:05 2017 -0700 drm/i915/cfl: Add Coffee Lake PCI IDs for S Skus. Signed-off-by:Liwei Song <liwei.song@windriver.com> Signed-off-by:
-
- 20 Dec, 2017 2 commits
-
-
Chris Wilson authored
Having requested an inactive snooped buffer, we know that it is already flushed and do not need to flush it again. With debugging enabled, we hit an assert while flushing that the buffer has a refcout, which at this present time of being plucked from the snoop cache it does not. Reported-by:
Adric Blake <promarbler14@gmail.com> References: https://bugs.freedesktop.org/show_bug.cgi?id=104341#c2 Signed-off-by:
-
Chris Wilson authored
Very early on when creating the sna privates, we call to_sna(scrn) before we have even set the sna->scrn backpointer. Reorder the code such that we always set sna->scrn before the first to_sna() so that the assert(to_sna(scrn)->scrn == scrn) can always hold. Signed-off-by:
-
- 16 Dec, 2017 1 commit
-
-
Chris Wilson authored
If we fail to manipulate a bo from the active cache for reuse, then we have to be careful not to immediately close it as it is still referenced from the current batch. Reported-by:
-
- 09 Nov, 2017 3 commits
-
-
Chris Wilson authored
Check that the struct sna we retrieve from the ScreenPtr points back to the screen, and vice versa. Signed-off-by: -
Chris Wilson authored
Xorg changed behaviour in 78f0667d6df9 (xf86Events: split xf86VTSwitch into xf86VTLeave and xf86VTEnter functions) and stopped altering the state of scrn->vtSema around calls to Leave/EnterVT. So we must do so ourselves (albeit a bit belated in noticing the change!) Signed-off-by: -
Chris Wilson authored
When being run as a secondary screen, we do not receive DPMS events (xf86DPMS() only operates on the primary screen, I guess one day we will have to fix that and undo this hack). As such we cannot defer the modesets until the final DPMS as it will never be sent. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=103618 Signed-off-by:
-
- 08 Nov, 2017 1 commit
-
-
Chris Wilson authored
The code expected that a fresh pixmap header to be created for each PRIME pixmap, but it appears that set_shared_pixmap is being called on the same pixmap with fd=-1. References: https://bugs.freedesktop.org/show_bug.cgi?id=103618 Signed-off-by:
-
- 18 Oct, 2017 1 commit
-
-
i830 can hang if 3DSTATE_BUFFER_INFO straddles two cachelines. To prevent that emit MI_NOOPs to align 3DSTATE_BUFFER_INFO to a cacheline boundary. Signed-off-by:
-
- 12 Oct, 2017 3 commits
-
-
Chris Wilson authored
Two pushes later and the discovery that the build scripts no longer do a debug build leads to some embarrassment. Signed-off-by: -
Chris Wilson authored
If the randr->rrPrimaryOutput is set to an output on a slave, we have to reject it in favour of one of our own. Signed-off-by: -
Chris Wilson authored
Avoid compiler trickery by making the layout of the sna_crtc_public pointed to by xf86CrtcPtr->devPrivate known. Signed-off-by:
-
- 08 Oct, 2017 2 commits
-
-
Chris Wilson authored
We need the debug code to be signalsafe as it may be run when updating the cursor from a signal. This excludes the use of fopen() as it may malloc (causing a potential recursion upon the malloc locks). Signed-off-by: -
Chris Wilson authored
Insert the keepalive vblank into the sorted list of msc carefully. This way we can discard redundant keepalives - as we don't want to queue a second event for the same vblank needlessly. Reported-by:
-
- 07 Oct, 2017 1 commit
-
-
Chris Wilson authored
Looks like a bug has snuck in somewhere in our set-tiling path. Since it exists, try to workaround it whilst it is root caused. Reported-by:
-
- 06 Oct, 2017 1 commit
-
-
Chris Wilson authored
If we can't change tiling on the cached bo and we expect an exact match (for e.g. scanout) then skip over the unwanted bo. Reported-by:
-
- 27 Sep, 2017 4 commits
-
-
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Signed-off-by:
-
