Commit d90a2ff1 authored by Chris Wilson's avatar Chris Wilson 🤔

Revert "sna: Close each client op with an arbitrartion check"

This reverts commit b5ac286c as it escaped before being completed.
It proved it's worth in preventing sna from hogging the GPU for too long
under x11perf stress, but it didn't check to see if there was enough
space left in the batch before emitting the dword. Simply revert the
patch for now.
Reported-by: Matti Hämäläinen's avatarMatti Hämäläinen <ccr@tnsp.org>
Closes: #174Signed-off-by: Chris Wilson's avatarChris Wilson <chris@chris-wilson.co.uk>
parent 0867eea6
......@@ -5302,8 +5302,6 @@ inline static void blt_done(struct sna *sna)
DBG(("%s: flushing BLT operation on empty ring\n",
__FUNCTION__));
_kgem_submit(&sna->kgem);
} else {
sna->kgem.batch[sna->kgem.nbatch++] = MI_ARB_CHECK;
}
}
......
......@@ -14,7 +14,6 @@
/* broadwater flush bits */
#define BRW_MI_GLOBAL_SNAPSHOT_RESET (1 << 3)
#define MI_ARB_CHECK (0x5 << 23)
#define MI_BATCH_BUFFER_END (0xA << 23)
/* Noop */
......
......@@ -32,7 +32,6 @@
#include "sna.h"
#include "sna_render.h"
#include "sna_render_inline.h"
#include "sna_reg.h"
#include "fb/fbpict.h"
#define NO_REDIRECT 0
......@@ -2130,8 +2129,6 @@ sna_render_composite_redirect_done(struct sna *sna,
kgem_bo_destroy(&sna->kgem, op->dst.bo);
}
batch_emit(sna, MI_ARB_CHECK);
}
static bool
......
Markdown is supported
0% or
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment