- 10 Jul, 2022 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 16 Jan, 2022 4 commits
-
-
Alan Coopersmith authored
Most were already converted. Fixes error raised by FlawFinder in CI: Error: encoding error in ./src/synaptics.c 'utf-8' codec can't decode byte 0xa9 in position 16: invalid start byte Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Found by using: codespell --builtin clear,rare,usage,informal,code,names Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 09 Apr, 2021 1 commit
-
-
Pip Cet authored
-
- 28 Jul, 2020 1 commit
-
-
Ariadne Conill authored
-
- 22 Jul, 2020 1 commit
-
-
Ariadne Conill authored
when building on a 32-bit host with 64-bit time_t, using the input_event and input_event_usec accessors are necessary to deal with translation.
-
- 11 Feb, 2019 1 commit
-
-
Silences clang warnings. Signed-off-by:
Matthieu Herrb <matthieu@herrb.eu> Reviewed-by:
Walter Harms <wharms@bfs.de> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 25 Nov, 2018 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 18 Nov, 2018 1 commit
-
-
Alan Coopersmith authored
Signed-off-by:
Alan Coopersmith <alan.coopersmith@oracle.com>
-
- 29 May, 2018 1 commit
-
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 15 May, 2018 1 commit
-
-
Peter Hutterer authored
Otherwise poll() keeps on triggering on our fd until udev gets around to notifying the server that the device is in some state of deadness. Meanwhile, the input thread is busy filling the log up with "Read error" messages. Great way to test file systems and their capacity to handle out of space scenarios but otherwise a bit pointless. Those FS developers should write their own tests instead of relying on the synaptics driver! Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Adam Jackson <ajax@redhat.com>
-
- 25 Oct, 2017 1 commit
-
-
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 17 Aug, 2017 1 commit
-
-
Peter Hutterer authored
With the removal of touch events in 0a4cf80a, this function is a noop. It merely counted the number of touches but discarded the result. And UpdateTouchState does the update anyway. https://bugs.freedesktop.org/show_bug.cgi?id=102209 Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 26 Jan, 2017 2 commits
-
-
Signed-off-by:
Mihail Konev <k.mvc@ya.ru>
-
Place quotes around the $srcdir, $ORIGDIR and $0 variables to prevent fall-outs, when they contain space. Signed-off-by:
Emil Velikov <emil.l.velikov@gmail.com> Reviewed-by:
Peter Hutterer <peter.hutterer@who-t.net> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 18 Nov, 2016 1 commit
-
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 09 Oct, 2016 1 commit
-
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 15 Sep, 2016 1 commit
-
-
Peter Hutterer authored
hw.x and the motion history are integers so our deltas are always integers. It's a bit pointless to split them into the fractional and integral part. obsolete since defc1d00 or so Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 17 Aug, 2016 1 commit
-
-
Peter Hutterer authored
If opening the fd fails we still need to fail the device. This is particularly the case when a device disappears before we can open it - the current code wouldn't exit but instead switch to auto-probe touchpad devices on the system. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Hans de Goede <hdegoede@redhat.com>
-
- 08 Aug, 2016 1 commit
-
-
When ignoring modifiers, ensure the touchpad is enabled once a modifier key is pressed disregarding any previous key press that caused the touchpad to be disabled. Signed-off-by:
Anton Lindqvist <anton.lindqvist@gmail.com> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 02 Jun, 2016 1 commit
-
-
Peter Hutterer authored
Use input_lock/input_unlock calls instead of SIGIO functions Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 23 May, 2016 1 commit
-
-
Bump up the synaptics driver to 70, so it get's preferred over libinput, which was dropped down to 60. The synaptics driver is more of a leaf package than libinput (which covers a multitude of device types) and can be removed by default. When specifically installed by the user, the synaptics driver should override the system default. Similar to what was done for wacom configuration file. https://bugzilla.suse.com/show_bug.cgi?id=979554 Signed-off-by:
Stefan Dirsch <sndirsch@suse.de> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 29 Apr, 2016 1 commit
-
-
Peter Hutterer authored
Fallout from 90c6d7fc where it got changed to 100ms. This is too short for triple-tap-and-drag gestures so revert it to the previous value. https://bugs.freedesktop.org/show_bug.cgi?id=95171 Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 28 Apr, 2016 1 commit
-
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 26 Apr, 2016 1 commit
-
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 12 Aug, 2015 2 commits
-
-
Peter Hutterer authored
This was a bad idea. No-one seems to use this and it gives us little benefits. To even get this feature a number of other features need to be turned off (like two-finger scrolling and tapping). Many of these are enabled by default, if they are disabled a client stack with full touchpad gesture support could in theory support true touchpad gestures. This has never happened. Drop the touch events from the synaptics driver. This allows us to switch the touchpad fully over to look like a relative device, thus also removing the bug that changes the touchpad speed whenever a monitor is added/removed in. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
Usually doesn't happen, but the evtest output in https://bugs.freedesktop.org/show_bug.cgi?id=90392 actually has repeat events for the button. Ignore them if they happen. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 24 Mar, 2015 2 commits
-
-
Peter Hutterer authored
An MT device without X/Y is not a touchpad. And neither are fake MT devices. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Hans de Goede <hdegoede@redhat.com>
-
Peter Hutterer authored
This came up as a kernel bug, but it's valid to create uinput devices with a min == max range for x/y. Technically valid, but effectively useless, so catch it, complain and hobble on along. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Hans de Goede <hdegoede@redhat.com>
-
- 17 Mar, 2015 1 commit
-
-
Peter Hutterer authored
This reverts commit 06444536. The Lenovo *50 series, including the X1 Carbon 3rd always require multiple kernel patches to enable the touchpad buttons. This patch in synaptics only addresses the re-routing of the top buttons. The final iteration of the kernel patches also route the trackpoint buttons through the trackpoint device, rendering this patch unnecessary. These patches are queued for 4.0. See kernel patch series up to commit cdd9dc195916ef5644cfac079094c3c1d1616e4c Author: Benjamin Tissoires <benjamin.tissoires@redhat.com> Date: Sun Mar 8 22:35:41 2015 -0700 Input: synaptics - re-route tracksticks buttons on the Lenovo 2015 series Currently in Dmitry's for-linus branch. Distributions running older kernels or the kernel stable series which has partial backports of the above patch series are encouraged to leave the 06444536 commit in and undo this revert. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Hans de Goede <hdegoede@redhat.com>
-
- 06 Mar, 2015 1 commit
-
-
Peter Hutterer authored
Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 18 Feb, 2015 1 commit
-
-
Some applications ignore the second tap of double taps because of the lack of a delay between the button down and button up events. Prevent this by replacing the transition from TS_2B to TS_START with a transition from TS_2B to TS_SINGLETAP that emits only a button down event. The button up event will be emitted when transitioning from TS_SINGLETAP to TS_START. In addition, decrease the default value of MaxDoubleTapTime from 180 ms to 100 ms in order to make double taps faster. Signed-off-by:
Gabriele Mazzotta <gabriele.mzt@gmail.com> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 29 Jan, 2015 1 commit
-
-
Peter Hutterer authored
This device has the trackpoint buttons wired up to the touchpad to send BTN_0, BTN_1 and BTN_2 for left, right, middle. This conflicts with previous touchpads that used those event codes for dedicated scroll buttons. Add an option HasTrackpointButtons that can be set via a xorg.conf.d snippets. This option is not intended as a user-set option, rather we expect distributions to ship some conglomerate of udev/hal rules with xorg.conf snippets that take effect. If the option is set, we look at the three affected buttons at the beginning of HandleState and send button events immediately for them. The HW state is reset to neutral and other processing continues. This saves us from having to synchronize these buttons with software buttons (also present on this device), tapping, etc. Since the buttons are physically different and (mentally) associated with the trackpoint device we also don't need to worry about having finger motion event correctly synced up with the button presses - it's acceptable to send the presses before the motion events. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Hans de Goede <hdegoede@redhat.com> Tested-by:
Benjamin Tissoires <benjamin.tissoires@gmail.com>
-
- 16 Jan, 2015 1 commit
-
-
The diagram didn't entirely reflect the current state of the code. Signed-off-by:
Gabriele Mazzotta <gabriele.mzt@gmail.com> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 12 Jan, 2015 1 commit
-
-
FastTap was removed with d14ea867 ("Purge fast-taps option"), remove all of what remained. Signed-off-by:
Gabriele Mazzotta <gabriele.mzt@gmail.com> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 07 Jan, 2015 1 commit
-
-
The palm detection relies on both the width and the pressure. a897147b ("Use ABS_MT events for the palm detection when supported") assumed that all the touch devices can report both ABS_MT_TOUCH_MAJOR and ABS_MT_PRESSURE, but this is not necessarily true. This assumption could hence break the palm detection when at least one of the mentioned events is not declared but both ABS_TOOL_WIDTH and ABS_PRESSURE are reported. Signed-off-by:
Gabriele Mazzotta <gabriele.mzt@gmail.com> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
- 17 Sep, 2014 2 commits
-
-
Use ABS_MT_TOUCH_MAJOR and ABS_MT_PRESSURE instead of ABS_TOOL_WIDTH and ABS_PRESSURE when supported so that the pressure and the width of all the fingers is taken into account for the palm detection. This also fixes the palm detection for those touchpads for which the kernel only sends ABS_MT_TOUCH_MAJOR and not ABS_TOOL_WIDTH. Signed-off-by:
Gabriele Mazzotta <gabriele.mzt@gmail.com> Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net>
-
Peter Hutterer authored
Touchpads are limited by a fixed sampling rate (usually 80Hz). Some finger changes may happen too fast for this sampling rate, resulting in two distinct event sequences: * finger 1 up and finger 2 down in the same EV_SYN frame. Synaptics sees one finger down before and after and the changed coordinates * finger 1 up and finger 2 down _between_ two EV_SYN frames. Synaptics sees one touchpoint move from f1 position to f2 position. That move causes a large cursor jump. The former could be solved (with difficulty) by adding fake EV_SYN handling after releasing touchpoints but that won't fix the latter case. So as a solution for now limit the finger movement to 20mm per event. Tests on a T440 and an x220 showed that this is just above what a reasonable finger movement would trigger. If a movement is greater than that limit, reset it to 0/0. On devices without resolution, use 0.25 of the touchpad's diagonal instead. Signed-off-by:
Peter Hutterer <peter.hutterer@who-t.net> Reviewed-by:
Hans de Goede <hdegoede@redhat.com>
-