1. 11 Mar, 2014 3 commits
  2. 26 Feb, 2014 7 commits
    • Peter Hutterer's avatar
      man: fix documentation about the new touchpad state · c431d900
      Peter Hutterer authored
      
      
      leftover from an earlier revision
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      c431d900
    • Hans de Goede's avatar
      Wait for *new* coordinates on a clickpad click before reporting the click · bbe4c56c
      Hans de Goede authored
      
      
      It is possible for a click to get reported before any related touch events
      get reported, here is the relevant part of an evemu-record session on a T440s:
      
      E: 3.985585 0000 0000 0000	# ------------ SYN_REPORT (0) ----------
      E: 3.997419 0003 0039 -001	# EV_ABS / ABS_MT_TRACKING_ID   -1
      E: 3.997419 0001 014a 0000	# EV_KEY / BTN_TOUCH            0
      E: 3.997419 0003 0018 0000	# EV_ABS / ABS_PRESSURE         0
      E: 3.997419 0001 0145 0000	# EV_KEY / BTN_TOOL_FINGER      0
      E: 3.997419 0000 0000 0000	# ------------ SYN_REPORT (0) ----------
      E: 5.117881 0001 0110 0001	# EV_KEY / BTN_LEFT             1
      E: 5.117881 0000 0000 0000	# ------------ SYN_REPORT (0) ----------
      E: 5.133422 0003 0039 0187	# EV_ABS / ABS_MT_TRACKING_ID   187
      E: 5.133422 0003 0035 3098	# EV_ABS / ABS_MT_POSITION_X    3098
      E: 5.133422 0003 0036 3282	# EV_ABS / ABS_MT_POSITION_Y    3282
      E: 5.133422 0003 003a 0046	# EV_ABS / ABS_MT_PRESSURE      46
      E: 5.133422 0001 014a 0001	# EV_KEY / BTN_TOUCH            1
      E: 5.133422 0003 0000 3102	# EV_ABS / ABS_X                3102
      E: 5.133422 0003 0001 3282	# EV_ABS / ABS_Y                3282
      E: 5.133422 0003 0018 0046	# EV_ABS / ABS_PRESSURE         46
      E: 5.133422 0001 0145 0001	# EV_KEY / BTN_TOOL_FINGER      1
      E: 5.133422 0000 0000 0000	# ------------ SYN_REPORT (0) ----------
      
      Notice the BTN_LEFT event all by itself!
      
      If this happens, it may lead to the following problem scenario:
      -touch the touchpad in its right click area
      -let go of the touchpad
      -rapidly click in the middle area, so that BTN_LEFT gets reported before the
       new coordinates (such as seen in the trace above, this may require some
       practicing with evemu-record to reproduce)
      -the driver registers the click as a right click because it uses the
       old coordinates from the cumulative coordinates to determine the
       click location
      
      This commit fixes this by:
      1) Resetting the cumulative coordinates not only when no button is pressed,
         but also when there is no finger touching the touchpad, so that when
         we do get a touch the cumulative coordinates start at the right place
      2) Delaying processing the BTN_LEFT down transition if there is no finger
         touching the touchpad
      
      This approach has one downside, if we wrongly identify a touchpad as
      a clickpad, then the left button won't work unless the user touches the
      touchpad while clicking the left button.
      
      If we want we can fix this by doing something like this:
      1) Making update_hw_button_state return a delay; and
      2) Tracking that we've delayed BTN_LEFT down transition processing; and
      3) When we've delayed BTN_LEFT down transition return a small delay value; and
      4) If when we're called again we still don't have a finger down, just
         treat the click as a BTN_LEFT
      
      But this is not worth the trouble IMHO, the proper thing to do in this
      scenario is to fix the mis-identification of the touchpad as a clickpad.
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      bbe4c56c
    • Hans de Goede's avatar
      On button down update cumulative to current x and y, instead of previous · 743c45b9
      Hans de Goede authored
      
      
      When a button click and new coordinates get reported in one go we sync the
      cumulative coordinates to the old x and y, rather then the newly reported ones.
      
      This keeping of the old coordinates causes the following issue:
      -touch the touchpad in its right click area
      -let go of the touchpad
      -rapidly click in the left click area (or middle area), so that the
       new location and the click get reported in one syn (may require some
       practicing with evemu-record to reproduce)
      -the driver registers the click as a right click because it uses the
       old coordinates from the cumulative coordinates to determine the
       click location
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      743c45b9
    • Hans de Goede's avatar
      Ignore motion the first X ms after a clickpad click · 71652fe1
      Hans de Goede authored
      This fixes my #1
      
       anoyance with clickpads, where 2 out of 3 clicks turn into
      a click + drag unless I hold my finger really really still.
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      
      Replaced property with a hardcoded 100ms. This is not something that we should
      expose as property, we should find a delay that works best and live with it.
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      71652fe1
    • Hans de Goede's avatar
      Don't report motion inside soft-button areas · 3adaf462
      Hans de Goede authored
      
      
      Unless the motion has started outside the soft-button area.
      
      Note that we must start reporting motions regardless of whether we think we're
      in the button area or not as soon as we've switched to using cumulative
      coordinates, since then the coordinates are no longer absolute.
      
      This fixes the reporting of unintended motion just before a click in a soft
      button area which sometimes causes mis-clicks.
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      3adaf462
    • Hans de Goede's avatar
      Get rid of old_hw_state · effeee86
      Hans de Goede authored
      
      
      We only use it to store button state which we already have in
      priv->lastButtons.
      
      While at it also properly indent the code block checking the various
      soft button areas.
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      effeee86
    • Hans de Goede's avatar
      Add an enum for the different soft_button_areas · 84067050
      Hans de Goede authored
      
      
      While at it also move the enum for the soft button edges out of
      is_inside_button_area() so that it can be used elsewhere too.
      Signed-off-by: default avatarHans de Goede <hdegoede@redhat.com>
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      84067050
  3. 23 Feb, 2014 3 commits
  4. 21 Feb, 2014 1 commit
  5. 20 Feb, 2014 1 commit
  6. 18 Feb, 2014 1 commit
  7. 17 Feb, 2014 1 commit
  8. 09 Feb, 2014 1 commit
    • Peter Hutterer's avatar
      Drop the half-baked test suite · 5d8cdaf4
      Peter Hutterer authored
      
      
      This suite was never really maintained anyway, and it is quite hard to do so
      anyway. The driver is linked to the server's API too tightly to easily do
      independent testing. We need to re-implement stubs for the API the driver
      uses, have to track API changes, etc. Not worth the effort.
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      5d8cdaf4
  9. 16 Jan, 2014 2 commits
  10. 06 Jan, 2014 1 commit
  11. 03 Jan, 2014 1 commit
  12. 04 Dec, 2013 1 commit
  13. 03 Dec, 2013 1 commit
  14. 06 Nov, 2013 1 commit
  15. 04 Nov, 2013 2 commits
  16. 14 Oct, 2013 1 commit
    • Peter Hutterer's avatar
      Switch to libevdev for the eventcomm backend · 41840a65
      Peter Hutterer authored
      
      
      This has a potential bug that would need to be fixed in mtdev first:
      if we get a SYN_DROPPED and we miss out on events, the current code emulates a
      normal EV_SYN, feeds that to mtdev and hopes that that fills the mtdev output
      queue.
      
      If mtdev doesn't generate events on that EV_SYN, we're stuck in limbo and may
      get weird results. The loop will continue and sync the device, but there's the
      off chance we get odd events.
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      41840a65
  17. 19 Jul, 2013 1 commit
  18. 13 May, 2013 1 commit
  19. 09 May, 2013 2 commits
  20. 26 Apr, 2013 1 commit
  21. 05 Apr, 2013 3 commits
  22. 02 Apr, 2013 1 commit
  23. 26 Mar, 2013 3 commits