1. 20 Apr, 2018 1 commit
  2. 17 Apr, 2018 2 commits
  3. 09 Apr, 2018 1 commit
  4. 22 Mar, 2018 1 commit
  5. 20 Mar, 2018 2 commits
  6. 20 Feb, 2018 1 commit
    • Peter Hutterer's avatar
      Apply the capabilities checks on subdevices when applying the config · 9d9f59fd
      Peter Hutterer authored
      Properties are initialized on the correct devices only but on resume we'd just
      blindly apply the config from our device. Depending on the resume order, this
      would mean we'd apply a previously set config with a default config.
      
      Example:
      * pointer device with keyboard subdevice
      * pointer device exports natural scrolling, keyboard device does not and
        remains at default (off)
      * client enables natural scrolling on the pointer device
      * VT switch away, VT switch back
      * pointer device gets enabled first, enables natural scrolling on the
        libinput device
      * keyboard device gets enabled second, resets to the default value
      Reported-by: yshui's avatarYuxuan Shui <yshuiv7@gmail.com>
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Tested-by: yshui's avatarYuxuan Shui <yshuiv7@gmail.com>
      9d9f59fd
  7. 02 Feb, 2018 2 commits
  8. 15 Sep, 2017 1 commit
  9. 17 Aug, 2017 1 commit
  10. 28 May, 2017 1 commit
  11. 18 May, 2017 1 commit
  12. 15 May, 2017 1 commit
  13. 08 May, 2017 1 commit
  14. 05 May, 2017 1 commit
  15. 22 Mar, 2017 1 commit
    • Peter Hutterer's avatar
      Post a motion event after proximity events · 8bc69459
      Peter Hutterer authored
      This patch splits the meat of xf86libinput_handle_tablet_axis into a helper
      function xf86libinput_post_tablet_motion(), to be called right after we send
      the proximity in event.
      
      Clients that don't handle proximity (e.g. all XI2 clients) don't see the
      coordinates we send along with the proximity events. And, for historical
      reasons, they may not look at the coordinates in button events. So a device
      that comes into proximity and immediately sends a tip down button event
      doesn't send a motion event, causing the client to think the tip down was at
      whatever the last known position was (before previous prox-out).
      
      The practical effect is that when a user tries to draw a few dots, they end up
      being connected to each other.
      
      https://bugzilla.redhat.com/show_bug.cgi?id=1433755Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      8bc69459
  16. 09 Mar, 2017 1 commit
  17. 28 Feb, 2017 1 commit
    • Peter Hutterer's avatar
      test: fix a test failure on ppc64(le) and aarch64 · 72fb6d30
      Peter Hutterer authored
      Caused by different results in -O0 vs -O2. The resulting array differs only
      slightly but the initial sequence has one extra zero. That triggers our
      assert, no other compiler flag seem to be affecting this.
      
      Compiled with -O0:
      Breakpoint 1, test_nonzero_x_linear () at test-bezier.c:157
      157			assert(bezier[x] > bezier[x-1]);
      (gdb) p bezier
      $6 = {0 <repeats 409 times>, 1, 2, 4, 5, 7, 9, 10, 12, 14, 15, 17, 19, 21, 22,
      
      Compiled with -O2:
      (gdb) p bezier
      $1 = {0 <repeats 410 times>, 1, 3, 5, 7, 9, 10, 12, 14, 15, 17, 19, 20, 22,
      
      Printing of the temporary numbers in the decasteljau function shows that a few
      of them are off by one, e.g.
          408.530612/0.836735 with O0, but
          409.510204/0.836735 with O2
      Note: these are not rounding errors caused by the code, the cast to int
      happens afterwards.
      
      Hack around this by allowing for one extra zero before we check that the rest
      of the curve is ascending again.
      
      https://bugs.freedesktop.org/show_bug.cgi?id=99992Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      72fb6d30
  18. 26 Feb, 2017 3 commits
  19. 09 Feb, 2017 1 commit
  20. 27 Jan, 2017 1 commit
  21. 26 Jan, 2017 2 commits
  22. 12 Jan, 2017 1 commit
    • Peter Hutterer's avatar
      Add tablet tool area ratio property · 974ab6b6
      Peter Hutterer authored
      By default, the X server maps the tablet axes to the available screen area.
      When a tablet is mapped to the screen but has a different aspect ratio than
      the screen, input data is skewed. Expose an area ratio property to map the
      a subsection of the available tablet area into the desired ratio.
      
      Differences to the wacom driver: there the x/y min/max values must be
      specified manually and in device coordinates. For this driver we merely
      provide the area ratio (e.g. 4:3) and let the driver work out the rest.
      Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Reviewed-by: Jason Gerecke's avatarJason Gerecke <jason.gerecke@wacom.com>
      974ab6b6
  23. 03 Jan, 2017 5 commits
  24. 20 Dec, 2016 1 commit
  25. 12 Dec, 2016 1 commit
  26. 05 Dec, 2016 1 commit
  27. 19 Nov, 2016 1 commit
    • Peter Hutterer's avatar
      If the parent libinput_device is unavailable, create a new one · 72bac84d
      Peter Hutterer authored
      The parent device ref's the libinput device during pre_init and unref's it
      during DEVICE_INIT, so the copy is lost. During DEVICE_ON, the libinput device
      is re-added and ref'd, this one stays around now. But the takeaway is: unless
      the device is enabled, no libinput device reference is available.
      
      If a device is a mixed pointer + keyboard device, a subdevice is created
      during a WorkProc. The subdevice relied on the parent's libinput_device being
      available and didn't even check for it. This WorkProc usually runs after
      the parent's DEVICE_ON, so in most cases all is well.
      
      But when running without logind and the server is vt-switched away, the parent
      device only runs PreInit and DEVICE_INIT but never DEVICE_ON, causing the
      subdevice to burn, crash, and generally fail horribly when it dereferences the
      parent's libinput device.
      
      Fix this because we have global warming already and don't need to burn more
      things and also because it's considered bad user experience to have the
      server crash. The simple fix is to check the parent device first and if it is
      unavailable, create a new one because it will end up disabled as well anyway,
      so the ref goes away as well. The use-case where the parent somehow gets
      disabled but the subdevice doesn't is a bit too niche to worry about.
      
      This doesn't happen with logind because in that case we don't get a usable fd
      while VT-switched away, so we can't even run PreInit and never get this far
      (see the paused fd handling in the xfree86 code for that). It can be
      reproduced by setting AutoEnableDevices off, but why would you do that,
      seriously.
      
      https://bugs.freedesktop.org/show_bug.cgi?id=97117Signed-off-by: Peter Hutterer's avatarPeter Hutterer <peter.hutterer@who-t.net>
      Reviewed-by: 's avatarHans de Goede <hdegoede@redhat.com>
      72bac84d
  28. 14 Nov, 2016 1 commit
  29. 01 Nov, 2016 2 commits